Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prov/efa: Add some missing newlines to log statements #10078

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

darrylabbate
Copy link
Member

No description provided.

Signed-off-by: Darryl Abbate <drl@amazon.com>
@darrylabbate darrylabbate requested a review from a team June 11, 2024 22:49
Comment on lines 98 to +101
"FI_EFA_TX_MIN_CREDITS was set to %d, which is <= 0.\n"
"This value will cause EFA communication to deadlock.\n"
"Please unset the environment variable or set it to a positive number.\n"
"Your application will now abort.",
"Your application will now abort.\n",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one (and another like it elsewhere) has always been an odd format, but I'll save that battle for another day.

@shijin-aws shijin-aws merged commit a820d27 into ofiwg:main Jun 12, 2024
13 checks passed
@darrylabbate darrylabbate deleted the fixup/efa/log-newlines branch June 12, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants