Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prov/efa: Add some missing newlines to log statements #10078

Merged
merged 1 commit into from
Jun 12, 2024
Merged

prov/efa: Add some missing newlines to log statements #10078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion prov/efa/src/efa_env.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ void efa_env_param_get(void)
"FI_EFA_TX_MIN_CREDITS was set to %d, which is <= 0.\n"
"This value will cause EFA communication to deadlock.\n"
"Please unset the environment variable or set it to a positive number.\n"
"Your application will now abort.",
"Your application will now abort.\n",
Comment on lines 98 to +101
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one (and another like it elsewhere) has always been an odd format, but I'll save that battle for another day.

efa_env.tx_min_credits);
abort();
}
Expand Down
2 changes: 1 addition & 1 deletion prov/efa/src/efa_hmem.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ ssize_t efa_copy_to_hmem_iov(void **desc, struct iovec *hmem_iov,
}

if (bytes_remaining) {
EFA_WARN(FI_LOG_CQ, "Source buffer is larger than target IOV");
EFA_WARN(FI_LOG_CQ, "Source buffer is larger than target IOV\n");
return -FI_ETRUNC;
}
return buff_size;
Expand Down
4 changes: 2 additions & 2 deletions prov/efa/src/rdm/efa_rdm_ep.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ bool efa_rdm_ep_support_rdma_write(struct efa_rdm_ep *ep)
static inline int efa_rdm_ep_cap_check_rma(struct efa_rdm_ep *ep) {
if ((ep->user_info->caps & FI_RMA) == FI_RMA)
return 0;
EFA_WARN_ONCE(FI_LOG_EP_DATA, "Operation requires FI_RMA capability, which was not requested.");
EFA_WARN_ONCE(FI_LOG_EP_DATA, "Operation requires FI_RMA capability, which was not requested.\n");
return -FI_EOPNOTSUPP;
}

Expand All @@ -364,7 +364,7 @@ static inline int efa_rdm_ep_cap_check_rma(struct efa_rdm_ep *ep) {
static inline int efa_rdm_ep_cap_check_atomic(struct efa_rdm_ep *ep) {
if ((ep->user_info->caps & FI_ATOMIC) == FI_ATOMIC)
return 0;
EFA_WARN_ONCE(FI_LOG_EP_DATA, "Operation requires FI_ATOMIC capability, which was not requested.");
EFA_WARN_ONCE(FI_LOG_EP_DATA, "Operation requires FI_ATOMIC capability, which was not requested.\n");
return -FI_EOPNOTSUPP;
}

Expand Down
6 changes: 3 additions & 3 deletions prov/efa/src/rdm/efa_rdm_ep_fiops.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ int efa_rdm_ep_create_base_ep_ibv_qp(struct efa_rdm_ep *ep)

if (!rx_rdm_cq && ofi_needs_rx(ep->base_ep.info->caps)) {
EFA_WARN(FI_LOG_EP_CTRL,
"Endpoint is not bound to a receive completion queue when it has receive capabilities enabled. (FI_RECV)\n");
"Endpoint is not bound to a receive completion queue when it has receive capabilities enabled (FI_RECV).\n");
return -FI_ENOCQ;
}

Expand Down Expand Up @@ -1329,7 +1329,7 @@ static int efa_rdm_ep_set_shared_memory_permitted(struct efa_rdm_ep *ep, bool sh
{
if (!shm_permitted) {
EFA_WARN(FI_LOG_EP_CTRL,
"FI_OPT_SHARED_MEMORY_PERMITTED set to false");
"FI_OPT_SHARED_MEMORY_PERMITTED set to false\n");
ep->shm_permitted = false;
return FI_SUCCESS;
}
Expand All @@ -1338,7 +1338,7 @@ static int efa_rdm_ep_set_shared_memory_permitted(struct efa_rdm_ep *ep, bool sh
EFA_WARN(FI_LOG_EP_CTRL,
"FI_OPT_SHARED_MEMORY_PERMITTED endpoint option set "
"to true but FI_EFA_ENABLE_SHM_TRANSFER environment "
"variable is set to false.");
"variable is set to false.\n");
return -FI_EINVAL;
}

Expand Down
Loading