New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fabric/av: Introduce FI_SOURCE_ERR flag #2811
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -313,6 +313,8 @@ additional optimizations. | |
require that the provider perform address translation and/or look-up | ||
based on data available in the underlying protocol in order to | ||
provide the requested data, which may adversely affect performance. | ||
The performance impact may be greater for address vectors of type | ||
FI_AV_TABLE. | ||
|
||
*FI_READ* | ||
: Indicates that the user requires an endpoint capable of initiating | ||
|
@@ -384,6 +386,14 @@ additional optimizations. | |
FI_LOCAL_COMM, for example NICs that lack loopback support, cannot | ||
be used to communicate with processes on the same system. | ||
|
||
*FI_SOURCE_ERR* | ||
: Must be paired with FI_SOURCE. When specified, this requests that | ||
raw source addressing data be returned as part of completion data | ||
for any address that has not been inserted into the local address | ||
vector. Use of this capability may require the provider to | ||
validate incoming source address data against addresses stored in | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Isn't it more of a lookup than a validate? |
||
the local address vector, which may adversely affect performance. | ||
|
||
Capabilities may be grouped into two general categories: primary and | ||
secondary. Primary capabilities must explicitly be requested by an | ||
application, and a provider must enable support for only those primary | ||
|
@@ -398,7 +408,7 @@ FI_DIRECTED_RECV, FI_READ, FI_WRITE, FI_RECV, FI_SEND, FI_REMOTE_READ, | |
and FI_REMOTE_WRITE. | ||
|
||
Secondary capabilities: FI_MULTI_RECV, FI_SOURCE, FI_RMA_EVENT, FI_SHARED_AV, | ||
FI_TRIGGER, FI_FENCE, FI_LOCAL_COMM, FI_REMOTE_COMM. | ||
FI_TRIGGER, FI_FENCE, FI_LOCAL_COMM, FI_REMOTE_COMM, FI_SOURCE_ERR. | ||
|
||
# MODE | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this
fi_addr_t
may not be inserted in any AV? Will this still get released when the AV is closed?