prov/verbs: detect string format of wildcard address #4386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an app passes a wildcard address in string format as node argument to fi_getinfo, we should return a passive fi_info. Signed-off-by: Arun C Ilango <arun.ilango@intel.com>
Merged
shefty
reviewed
Sep 5, 2018
src/common.c
Outdated
| @@ -595,11 +598,42 @@ int ofi_addr_cmp(const struct fi_provider *prov, const struct sockaddr *sa1, | |||
| } | |||
| } | |||
|
|
|||
| int ofi_is_only_src_port_set(const char *node, const char *service, | |||
| uint64_t flags, const struct fi_info *hints) | |||
| static int ofi_is_any_addr_port(void *addr) | |||
There was a problem hiding this comment.
This function assumes that addr is a struct sockaddr *, instead of void *.
There was a problem hiding this comment.
Thanks. Fixed the function signature.
dmitrygx
approved these changes
Sep 6, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an app passes a wildcard address in string format as node argument to
fi_getinfo, we should return a passive fi_info.