fabtests/rdm_tagged_peek: fix race condition synchronization #8859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was possible for the client to complete the finalize send before the server gets the last 0xabc completion, causing a tag mismatch when processing the incorrect receive. This removes the extra synchronization sends and adds an OOB sync to make sure all of the test sends have finished before quitting the test. Signed-off-by: Alexia Ingerson <alexia.ingerson@intel.com>
|
I think we can revert this then 4aa3fa9. If you want to make it a separate PR, I can do it. |
|
@shijin-aws Oh good point. I'll add that here so we can test it in this PR. |
This reverts commit 4aa3fa9 which disabled the test which was failing sockets. The test issue was resolved. Signed-off-by: Alexia Ingerson <alexia.ingerson@intel.com>
shefty
approved these changes
Apr 26, 2023
|
Let's hope this is the last we see of tagged_peek issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible for the client to complete the finalize send before the server gets the last 0xabc completion, causing a tag mismatch when processing the incorrect receive.
This removes the extra synchronization sends and adds an OOB sync to make sure all of the test sends have finished before quitting the test.