TreeLayout only handles TreeLayout::RootSelectionType::Source #102
Conversation
✅ Doxygen Documentation successfully built!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lypoluz
force-pushed
the
dpotulski-treelayout
branch
3 times, most recently
from
7636605
to
449bed4
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
I tested this "manually" by setting m_selectRoot = RootSelectionType::Sink in TreeLayout::call() directly and reversing the edges of the arborescences in graphs.h via G.reverseAllEdges(). When running test-misc --only=TreeLayout, it did not crash but ran into an infinite while-loop. So to me it seems like this does not work at all, am I missing something?
The reason appears to be that the constructed TreeStructure later also assumes that the graph is always an out-arborescence. So (at least) the checks in TreeStructure would also have to be changed.
doc/porting/unreleased.md
Outdated
|
|
||
| #### A new parameter 'outTree' was added to isArborescence(...) and isArborescenceForest(...). | ||
| By default it is set to true. | ||
| If set to false, root nodes are handled as sinks. |
There was a problem hiding this comment.
Since the default behavior is the same, and thus people do not need to change their code because of this change, we do not need to add anything to the porting guide.
(Which also solves the problem that currently, line 5 would be a lie. 😄)
lypoluz
force-pushed
the
dpotulski-treelayout
branch
from
449bed4
to
5b712a5
Compare
Addresses issue #195 (314 on GitLab).
The layout may not be what one would expect but it does not crash anymore.
Adjusting the layout would require further work.