179 - more graph operations #230
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Doxygen Documentation successfully built!
To edit notification comments on pull requests, go to your Netlify site configuration. |
N-Coder
approved these changes
Jan 24, 2024
lypoluz
force-pushed
the
179-more-graph-operations
branch
from
c493447
to
3895122
Compare
N-Coder
reviewed
Feb 22, 2024
N-Coder
approved these changes
Mar 26, 2024
| void join(Graph& G1, const Graph& G2, NodeArray<node>& nodeMap) { | ||
| OGDF_ASSERT(nodeMap.valid()); | ||
| void join(Graph& G1, const Graph& G2, NodeArray<node>& mapping) { | ||
| OGDF_ASSERT(mapping.valid()); |
There was a problem hiding this comment.
Instead of (or maybe in addition to) valid() I'd rather check mapping.graphOf() == &G2
| it("creates an edge where there was none", [&]() { | ||
| complement(G, false, false); | ||
| edge edge12 = G.searchEdge(n1, n2); | ||
| AssertThat(edge12, Is().Not().Null()); |
There was a problem hiding this comment.
There's also !IsNull() if that is more convenient to you...
lypoluz
force-pushed
the
179-more-graph-operations
branch
from
bef8075
to
ea5557b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding additional graph operations. These include
complement,intersectionandjoin.