feat: use of conventient errors for sec errors as well. Also fixed recordErr. #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use convenient errors inside security handlers as well. This way we can format security responses without modifying error handler.
alesbrelih
force-pushed
the
feat/sec-conventient-err
branch
2 times, most recently
from
6bfb125
to
6b5b9c5
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1033 +/- ##
==========================================
- Coverage 72.23% 72.21% -0.02%
==========================================
Files 192 192
Lines 15003 15003
==========================================
- Hits 10837 10835 -2
- Misses 3631 3632 +1
- Partials 535 536 +1 ☔ View full report in Codecov by Sentry. |
alesbrelih
force-pushed
the
feat/sec-conventient-err
branch
from
6b5b9c5
to
1d6bddb
Compare
|
Wops, forgot to regenerate code after the second commit. |
tdakkota
requested changes
Sep 10, 2023
Using convenient errors recordErr was called everytime. It shouldn't be run for non 500 status codes.
alesbrelih
force-pushed
the
feat/sec-conventient-err
branch
from
d01c419
to
9088f91
Compare
tdakkota
approved these changes
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use convenient errors inside security handlers as well.
This way we can format security responses without modifying error handler which seems a bit better I think. But this can be a breaking change, because if someone is using convenient errors now, they will get 500 error or what they mapped their default response.
If you think I should put this under a new flag, please let me know (or any other suggestion)
Also:
Using convenient errors recordErr was called everytime. It shouldn't be called for non 500 status codes. I've updated this in the second commit.