Fix time zone handling with TZ=:/absolute/path #911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
determine_time_zone() assumes that a `TZ` environment variable that starts with `:` is a relative path, so `TZ=:/absolute/path` tries (and fails) to load zone info from `/usr/share/zoneinfo//absolute/path`. The GNU libc manual suggests that both `:relative/path` (mapping to `/usr/share/zoneinfo/relative/path`) and `:/absolute/path` should work.
|
Ah, I’m sorry! I already did the job there: #857, but I didn’t merge it. I thought about it and then wrote #867 which might fix the problem in a better way, but since it’s a bigger change, I’d prefer to know if exa’s author agree with it. Feel free to comment on #857 if you think it could be improved, though, even if I would strongly prefer #867 be merged instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
determine_time_zone() assumes that a
TZenvironment variable thatstarts with
:is a relative path, soTZ=:/absolute/pathtries(and fails) to load zone info from
/usr/share/zoneinfo//absolute/path.The GNU libc manual suggests that both
:relative/path(mapping to
/usr/share/zoneinfo/relative/path)and
:/absolute/pathshould work.