Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace datetime and zoneinfo_compiled crates with chrono #867

Closed
wants to merge 1 commit into from

Conversation

ariasuni
Copy link
Collaborator

@ariasuni ariasuni commented May 9, 2021

After hours of pain trying to retro-engineer several libc including glibc, musl and Bionic (Android), I’ve come to the conclusion that it’s the wrong approach. But I couldn’t understand the mess that’s time and timezone handling in C, much less investigate every OS we would like exa to support.

Fortunately, chrono already provides us a nice Rust layer on top of all the nasty C platform-dependent code. Apart from Android, chrono also supports Windows.

  • Improve compatibility with other OSes, timezone are handled for us
  • Reduce significantly code handling and rendering time

Fix #620
Fix #712
Fix #856
Fix #1047

Close #846
Close #857

@dbeckwith
Copy link

I just started using NixOS and I'm seeing Unable to determine time zone: No such file or directory (os error 2) from exa v0.10.1. Does this PR cover fixing that?

@dbeckwith
Copy link

I guess it might be #856 which is fixed by this?

@dbeckwith
Copy link

Actually I was able to fix the error just by setting the time.timeZone NixOS config option.

@fkarg
Copy link

fkarg commented Mar 26, 2022

@dbeckwith I seem to have the same issue, though I have time.timeZone set properly

@ariasuni
Copy link
Collaborator Author

Please open an issue or comment under an existing issue so I can keep track of that properly.

@fkarg
Copy link

fkarg commented Mar 26, 2022

I found this PR after you linked it from my issue #1047 :)

- Improve compatibility with other OSes, timezone are handled for us
- Reduce significantly code handling and rendering time
@mrkline
Copy link

mrkline commented Jun 17, 2022

Is this blocked on anything? I would love to see it merged - exa continues to have trouble with the time zone on several of my machines due to how the TZ environment variable is handled. PRs to correct TZ handling per the glibc manual were closed in lieu of this PR. (see #911)

@txtsd
Copy link

txtsd commented Feb 8, 2023

This PR makes it work properly on my Arch machine. Can it be merged soon?

@tkapias
Copy link

tkapias commented Mar 6, 2023

Same for me on Debian testing, I never had this issue before, but I often use export TZ=:/etc/localtime in bash scripts. And today after some updates I-m now getting Unable to determine time zone: No such file or directory (os error 2) when I use exa -l. Please release this PR.

@StayPirate
Copy link

@ogham can you please merge/release this one?

@txtsd
Copy link

txtsd commented Aug 24, 2023

@ariasuni @ogham Please bump the priority up on this one.

@ariasuni
Copy link
Collaborator Author

Closing this, since exa is unmaintained (see #1243), and this has (finally 🎉) been merged in the active fork eza!

@ariasuni ariasuni closed this Sep 11, 2023
@ariasuni ariasuni deleted the use-chrono branch September 11, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants