Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actualización #3

Merged
merged 92 commits into from
Sep 12, 2017
Merged

Actualización #3

merged 92 commits into from
Sep 12, 2017

Conversation

ogsilvaa
Copy link
Owner

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No ReSharper warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the dev branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

aloisdg and others added 30 commits June 27, 2016 13:22
For example on `ToOrdinalWords` the Arabic example was incorrectly listed as 'Brazilian Portuguese'
Fixed misspelling of "Uper" to "Upper".
Fix CONTRIBUTING.md of broken links.
added translation for DateHumanize_Now
Pass through the content of the "Letter, other" Unicode category.
commit f9423de
Author: hangy <hangy@hangy.de>
Date:   Thu Dec 1 20:48:01 2016 +0100

    Update TimeSpanHumanizeTests.cs

commit 2e5dfe5
Author: hangy <hangy@hangy.de>
Date:   Thu Dec 1 20:37:50 2016 +0100

    Apparently I'm stupid and 7 days actually get humanized as 1 week.

commit 152a119
Author: hangy <hangy@hangy.de>
Date:   Wed Nov 30 23:50:51 2016 +0100

    Workaround for unneeded suffix: Just use the same value.

    The reason for this workaround is that at the method that decides if the suffix should be applied, the information about the time unit is not available. So it would either need to do some string magic and explicitly exclude the "TimeSpanHumanize_MultipleDays" resource key from adding the postfix, or most of the `TimeSpan` formatting code would need to be rewriten for Croatian or modified for all languages to support Croatian. Neither seems reasonable for a quick change.

commit 002cc7b
Author: hangy <hangy@hangy.de>
Date:   Wed Nov 30 23:12:57 2016 +0100

    Added some more tests. From what I've read, all days should resolve to "dana" for the Croatian language. (No "_DualTrialQuadral" postfix.")

commit c190e9d
Author: hangy <hangy@hangy.de>
Date:   Tue Nov 22 00:29:51 2016 +0100

    Add initial test for issue 597.
Add resource value validation for DefaultFormatter
Add Esperanto support to NumberToWords. Fixes #558
Revert "Add Esperanto support to NumberToWords. Fixes #558"
Workaround for Croatian TimeSpan localization bug
According to #601, the localisation is good for
Portuguese in general, not just for Brazilian Portuguese.
I copied the unit test, so that we can prove that there's no regression.

Additionally, I copied the `OrginalizeTests`, because those were
already registered as "pt", not "pt-BR".

Note that `NumberToWords` is still only valid for pt-BR unless confirmed
otherwise.
Very minor correction to the syntax. Named parameters require a :, not a =. 

(I found this when I copy/pasted the code and it didn't work without changes)
MaStr11 and others added 29 commits May 3, 2017 22:09
…ked reviewed language with "Native speaker". Marked 'sv' as reviewed even confirmation is pending.
…umanizeExtensions

Fuzzy month years logic for time span humanize extensions
Added support for Greek language in resources
#632 Continued: Fuzzy month years logic for time span humanize extensions
@ogsilvaa ogsilvaa merged commit f8ccb7b into ogsilvaa:master Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet