pg adapter leaks symbols in rows

[gabssnake]

Hello again,
We noticed that rows being return from pg adapter queries include Symbol(_id).
This is mostly aesthetic, but can be confusing. I'll be happy try a PR, do you have any pointers ?
Best,

// pg-mem/src/tests/pg.spec.ts

it('does not leak symbol properties in rows', async () => {
    simpleDb();
    const { Client } = db.adapters.createPg();
    const client = new Client();
    await client.connect();

    many(`create table mytable (msg varchar);
        insert into mytable values ('hello'), ('hi');`);

    const got = await client.query('select * from mytable;');

    // fails
    expect(Object.getOwnPropertySymbols(got.rows[0]).length).to.be.equal(0);

    await client.end();
});

[oguimbal]

I guess that you could clone the results using somehting like Object.fromEntries(Object.entries(myRow)) in adaptResults() to get rid of the symbols

[gabssnake]

There it goes :-)

[gabssnake]

unfortunately, had to revert the usage of Object.fromEntries because tests fail on node 10.x

[A7med-Ragheb]

Hi @gabssnake @oguimbal,
Kindly, do you have an update regarding this issue? Are you working on another fix?

[oguimbal]

This fix is merged, but not yet shipped in the latest version.

That said, I fail to see how those attached symbols are annoying... They are almost transparent, arent they?

[A7med-Ragheb]

@oguimbal It is annoying as I'm using this library for my unit tests to test the repository layer in my application and I want to compare the returned results from DB with the expected results and this is always failing as there are two extra values I didn't add them in my table.

Kindly, When it will be shipped to the latest version?

[oguimbal]

@A7med-Ragheb this shipped with pg-mem@1.9.12