Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version upgrades, add type aliases #377

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

secam
Copy link
Contributor

@secam secam commented Jan 9, 2024

  • Upgraded dependencies for knex, mikro-orm, typescript, immutable...
  • Changed imports to work with new versions
  • upgraded parser to 12.0.1 (removed set names hack)
  • Added type aliases for setial8 and int8
  • Added test for string insert into bigint columns (mikro-orm does this)
  • Added alter enum support

@oguimbal
Copy link
Owner

Hi, I think this PR will have a lot of conflicts with #351 ... @knixeur @secam how would you like to proceed ?
Can your merge both PRs in a single PR ? Or should I merge one of those and you'll handle conflicts in the other ? In that case, which one do you prefer I merge first ?

@secam
Copy link
Contributor Author

secam commented Jan 10, 2024

I think all the stuff from #351 should be skipped if we merge this. Beause #351 also upgrades mikro-orm but reimplementing workaround, that is completely removed in this PR

@knixeur
Copy link

knixeur commented Jan 10, 2024

Sure go ahead, I'll close mine 👍

@oguimbal oguimbal merged commit 591fec5 into oguimbal:master Jan 11, 2024
4 checks passed
@oguimbal
Copy link
Owner

released as pg-mem@2.8.1 thanks for this nice PR @secam !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants