add dpaste plugin #170

rominf · 2014-06-08T17:49:21Z

Just a dpaste (https://github.com/bartTC/dpaste) wrapper

bpinto · 2014-06-11T01:52:52Z

➜ .oh-my-fish git:(rominf-dpaste) dpaste
➜ .oh-my-fish git:(rominf-dpaste) dpaste --help
➜ .oh-my-fish git:(rominf-dpaste)

Nothing being printed. Something I'm doing wrong?

rominf · 2014-06-11T14:28:22Z

Well, I forgot to add --help option (I added only -h), but I don't understand why it don't show anything for you. It's wrong. Can you check your sed? Does it have -r option ("normal" regexp)?

bpinto · 2014-06-11T15:58:29Z

My sed does not have -r options. I'm running Maverick (osx).

➜ .oh-my-fish git:(rominf-dpaste) sed -
-a  (Delay opening files until a command containing the related 'w' function is applied)  -e  (Evaluate expression)  -i  (Edit files in place)  -n  (Silent mode)
-E                                                                 (Use extended regexp)  -f         (Evalute file)  -l   (Use line buffering)

➜ .oh-my-fish git:(rominf-dpaste) dpaste --help
Usage:
  dpaste [-t EXPIRES] < README.md
  dpaste [-t EXPIRES] README.md
  cat README.md | dpaste [-t EXPIRES]
  dpaste [-t EXPIRES] "I \<3 to paste"

Options:
  -t EXPIRES  set snippet expiration time: (onetime|never|hour|week|month) [default: month]

➜ .oh-my-fish git:(rominf-dpaste) dpaste
sed: illegal option -- r
usage: sed script [-Ealn] [-i extension] [file ...]
       sed [-Ealn] [-i extension] [-e script] ... [-f script_file] ... [file ...]
sed: illegal option -- r
usage: sed script [-Ealn] [-i extension] [file ...]
       sed [-Ealn] [-i extension] [-e script] ... [-f script_file] ... [file ...]
sed: illegal option -- r
usage: sed script [-Ealn] [-i extension] [file ...]
       sed [-Ealn] [-i extension] [-e script] ... [-f script_file] ... [file ...]

KamilaBorowska · 2014-06-11T16:03:16Z

sed -r is GNU extension. You may want to fix your script to not depend on sed -r.

rominf · 2014-06-11T19:14:51Z

Writing with standard POSIX regexes is painful as hell (consider: \(never\|onetime\|hour\)). I adopted advice describing extended regexes usage in other OS. Can you please try it again? To simplify it I provided tests. Install https://github.com/terlar/fish-tank as described and run fish plugins/dpaste/tests/test_dpaste.fish.

Thank you, @terlar for providing unit testing framework!

bpinto · 2014-06-11T19:24:11Z

Tests are great! I'll take a look at fish-tank.

Why not use -E always?

rominf · 2014-06-11T19:57:46Z

Well, there is no reason to use -r instead of -E in this situation. I just messed up with tests and thought that they don't work because of -E flag. Now I'm using -E everywhere.

bpinto · 2014-06-11T20:14:08Z

It hangs forever when dpaste is called without arguments.

rominf · 2014-06-12T10:48:03Z

Do tests work?
Well, I don't have ideas how to debug this issue.
BTW how can I log via stderr? I know how I can check for variable and how to echo to stderr. But it's cumbersome to do this in every line of logging. Is there something like Python's logging facilities?

bpinto · 2014-07-16T18:00:46Z

I still need to test this.

bpinto · 2014-08-15T03:03:23Z

Sorry that I took so long! I really enjoy this plugin.

➜ .oh-my-fish git:(master) fish plugins/dpaste/tests/test_dpaste.fish

# Running:

source: Error encountered while sourcing file '../dpaste.fish':
source: No such file or directory
fish: Unknown command '__dpaste_set_defaults'
- (line 3):     __dpaste_set_defaults
                ^
in function 'setup'
    called on line 19 of file /usr/local/share/fish-tank/functions/__tank_run_tests.fish

in function '__tank_test_setup'
    called on line 2 of file /usr/local/share/fish-tank/functions/__tank_run_tests.fish
    with parameter list 'test_dpaste_parse_expires'

in event handler: handler for generic event 'test_run'

fish: Unknown command '__dpaste_parse_expires'
- (line 1): __dpaste_parse_expires text
            ^
in command substitution
    called on line 6 of file -

in function 'test_dpaste_parse_expires'
    called on line 1 of file -

from sourcing file -
    called on line 35 of file /opt/boxen/homebrew/Cellar/fish/HEAD/share/fish/functions/eval.fish

in function 'eval'
    called on line 10 of file /usr/local/share/fish-tank/functions/__tank_run_tests.fish

in function '__tank_run_tests'
    called on line 5 of file /usr/local/share/fish-tank/functions/tank_run_suite.fish
    with parameter list 'suite_dpaste'

in function 'tank_run_suite'
    called on line 11 of file /usr/local/share/fish-tank/functions/tank_run.fish
    with parameter list 'suite_dpaste'

in function 'tank_run'
    called on line 25 of file ~/.oh-my-fish/plugins/dpaste/tests/test_dpaste.fish

fish: Unknown command '__dpaste_parse_expires'
- (line 1): __dpaste_parse_expires -t never text
            ^
in command substitution
    called on line 6 of file -

in function 'test_dpaste_parse_expires'
    called on line 1 of file -

from sourcing file -
    called on line 35 of file /opt/boxen/homebrew/Cellar/fish/HEAD/share/fish/functions/eval.fish

in function 'eval'
    called on line 10 of file /usr/local/share/fish-tank/functions/__tank_run_tests.fish

in function '__tank_run_tests'
    called on line 5 of file /usr/local/share/fish-tank/functions/tank_run_suite.fish
    with parameter list 'suite_dpaste'

in function 'tank_run_suite'
    called on line 11 of file /usr/local/share/fish-tank/functions/tank_run.fish
    with parameter list 'suite_dpaste'

in function 'tank_run'
    called on line 25 of file ~/.oh-my-fish/plugins/dpaste/tests/test_dpaste.fish

fish: Unknown command '__dpaste_parse_expires'
- (line 1): __dpaste_parse_expires -t hour text
            ^
in command substitution
    called on line 6 of file -

in function 'test_dpaste_parse_expires'
    called on line 1 of file -

from sourcing file -
    called on line 35 of file /opt/boxen/homebrew/Cellar/fish/HEAD/share/fish/functions/eval.fish

in function 'eval'
    called on line 10 of file /usr/local/share/fish-tank/functions/__tank_run_tests.fish

in function '__tank_run_tests'
    called on line 5 of file /usr/local/share/fish-tank/functions/tank_run_suite.fish
    with parameter list 'suite_dpaste'

in function 'tank_run_suite'
    called on line 11 of file /usr/local/share/fish-tank/functions/tank_run.fish
    with parameter list 'suite_dpaste'

in function 'tank_run'
    called on line 25 of file ~/.oh-my-fish/plugins/dpaste/tests/test_dpaste.fish

Eexpr: not a decimal number: '1408071782N'
(standard_in) 1: parse error


Finished in 0s

  1) Error:
suite_dpaste#test_dpaste_parse_expires:
Wrong number of arguments

1 runs, 1 assertions, 0 failures, 1 errors, 0 skips

bpinto · 2014-08-15T03:06:21Z

Something I noticed is that there is no completion when you do a dpaste - TAB. It would be a nice addition.

rominf · 2014-08-15T08:27:52Z

Something I noticed is that there is no completion when you do a dpaste - TAB.

I wanted to make this plugin user-friendly (in terms of arguments processing). But then I realized that it's harder work than in python, for example, because of lack of argument parsing framework. I will wait until fish-shell/fish-shell#478 will be closed.

rominf · 2014-08-15T08:49:31Z

Test script used relative path to the cwd. I fixed it (see last commit).

bpinto · 2014-08-15T16:02:48Z

Good. Now it's freezing on "# Running: ". I'll try to understand it.

Okay, I had to do the following changes to execute the tests: https://dpaste.de/GMzY
Failing scenario: https://dpaste.de/1oRS

rominf · 2014-08-15T20:36:00Z

Due scoping
source (dirname (status -f))/../dpaste.fish
should be executed after
set -g __dpaste_expires_choises

I don't know why running
source (dirname (status -f))/../dpaste.fish
in function setup don't work for you. I suggest you to ask @terlar (https://github.com/terlar/fish-tank).

Try this version.

rominf · 2014-08-15T20:42:22Z

Did you install the latest version of fish-tank BTW?

terlar · 2014-08-16T11:52:29Z

For me the tests are passing on rominf:oh-my-fish/dpaste. Let me know if you find a way to reproduce some issue and I will look into it.

If you want to see how to use the test-framework I suggest looking into fry. That is usually what I use to develop the test-framework. I have plans to add some tests to the the actual fish-tank, but the plan to let fish-tank test itself has not been very successful so far.

bpinto · 2014-11-20T22:14:45Z

@rominf where are we on this PR?

rominf · 2014-11-20T22:17:11Z

@bpinto
That's depends on what do you mean by "we". For me (and for others as I understood), plugin works. You had some problems as I remember. Tests didn't pass on your OS X.

bpinto · 2014-11-20T22:20:25Z

Is this the correct output now?

.oh-my-fish:rominf-dpaste λ fish plugins/dpaste/tests/test_dpaste.fish

# Running:

.expr: not a decimal number: '1416521991N'
(standard_in) 1: parse error


Finished in 0s

1 runs, 6 assertions, 0 failures, 0 errors, 0 skips

rominf · 2014-11-20T22:27:12Z

Is this the correct output now?

.oh-my-fish:rominf-dpaste λ fish plugins/dpaste/tests/test_dpaste.fish

# Running:

.expr: not a decimal number: '1416521991N'
I'm not sure. I'll take a look tomorrow.

rominf · 2014-11-25T19:15:31Z

Well, I don't understand the meaning of this line (on my PC there is no such line):

.expr: not a decimal number: '1416521991N'

Everything else looks good.

rominf · 2014-11-25T21:05:22Z

Can you try my tests again? I've included system tests. I believe they check most of aspects of this plugin.

Enable detailed output and then run my tests:

$ set -U tank_reporter spec
$ cd plugins/dpaste/tests
$ ./test_dpaste.fish

# Running:

suite_dpaste
  ✓ test_dpaste_parse_expires
  ✓ test_dpaste_parse_expires_1
  ✓ test_dpaste_parse_expires_hour
  ✓ test_dpaste_parse_expires_never
  ✓ test_dpaste_system_file
  ✓ test_dpaste_system_file_redirect
  ✓ test_dpaste_system_stdin
  ✓ test_dpaste_system_text

Finished in 5.01s

8 runs, 16 assertions, 0 failures, 0 errors, 0 skips

bpinto · 2014-11-26T05:16:27Z

.oh-my-fish:rominf-dpaste λ set -U tank_reporter spec
.oh-my-fish:rominf-dpaste λ cd plugins/dpaste/tests
tests:rominf-dpaste λ ./test_dpaste.fish

# Running:

suite_dpaste
  ✓ test_dpaste_parse_expires
  ✓ test_dpaste_parse_expires_1
  ✓ test_dpaste_parse_expires_hour
  ✓ test_dpaste_parse_expires_never
  ✓ test_dpaste_system_file
  ✓ test_dpaste_system_file_redirect
  ✓ test_dpaste_system_stdin
  ✓ test_dpaste_system_text
expr: not a decimal number: '1416978869N'
(standard_in) 1: parse error

Finished in 0s

8 runs, 16 assertions, 0 failures, 0 errors, 0 skips

That is possibly an issue with my fish tank version. Would you like to rebase so we can get it merged?

terlar · 2014-11-26T07:22:39Z

What system are you running? Linux, BSD or OSX?

This is definately something with the date binary. On Linux it takes the %N to get milliseconds, but if I remember correctly OSX/BSD doesn't support this.

Everything is okay, it is only the run time that is missing because of this issue.

rominf · 2014-11-26T11:03:15Z

You can merge it, @bpinto. Now dpaste is 100% awesome, I promise you.

bpinto · 2014-11-28T08:44:41Z

@terlar Thanks for the explanation.
@rominf You rock!
Merged.

rominf · 2014-11-28T08:52:35Z

@bpinto Thank you!

rominf added 3 commits November 26, 2014 17:10

[dpaste] Add dpaste plugin

75ad45c

[dpaste] Add "expires" option

4ec5b92

[dpaste] Underscoring all private variables and functions

790b3b7

rominf added 12 commits November 26, 2014 17:11

[dpaste] Fixed file pasting with option -t

ef1e308

[dpaste] Add --help alias for help

4b95634

[dpaste] Add compatibility with non GNU *nix

1a51621

[dpaste] Add tests

22581fc

[dpaste] Fix tests

124b31d

[dpaste] Fix hour, week, month expired snippets

06556e5

[dpaste] Using sed -E everywhere

529f1d1

[dpaste] Allow test run with any working directory

2e12fb3

[dpaste] Another try to fix tests running on OS X

8f92518

[dpaste] Add system tests

434f665

[dpaste] Add time options: 1, onetime, 2, twotimes

8825d3e

[dpaste] Make dpaste a replacement for sprunge

cb92e60

bpinto closed this Nov 28, 2014

bpinto added a commit that referenced this pull request Nov 28, 2014

Merge pull request #170 from rominf/dpaste

c56d016

rominf deleted the dpaste branch January 5, 2015 22:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add dpaste plugin #170

add dpaste plugin #170

rominf commented Jun 8, 2014

bpinto commented Jun 11, 2014

rominf commented Jun 11, 2014

bpinto commented Jun 11, 2014

KamilaBorowska commented Jun 11, 2014

rominf commented Jun 11, 2014

bpinto commented Jun 11, 2014

rominf commented Jun 11, 2014

bpinto commented Jun 11, 2014

rominf commented Jun 12, 2014

bpinto commented Jul 16, 2014

bpinto commented Aug 15, 2014

bpinto commented Aug 15, 2014

rominf commented Aug 15, 2014

rominf commented Aug 15, 2014

bpinto commented Aug 15, 2014

rominf commented Aug 15, 2014

rominf commented Aug 15, 2014

terlar commented Aug 16, 2014

bpinto commented Nov 20, 2014

rominf commented Nov 20, 2014

bpinto commented Nov 20, 2014

rominf commented Nov 20, 2014

rominf commented Nov 25, 2014

rominf commented Nov 25, 2014

bpinto commented Nov 26, 2014

terlar commented Nov 26, 2014

rominf commented Nov 26, 2014

bpinto commented Nov 28, 2014

rominf commented Nov 28, 2014

add dpaste plugin #170

add dpaste plugin #170

Conversation

rominf commented Jun 8, 2014

bpinto commented Jun 11, 2014

rominf commented Jun 11, 2014

bpinto commented Jun 11, 2014

KamilaBorowska commented Jun 11, 2014

rominf commented Jun 11, 2014

bpinto commented Jun 11, 2014

rominf commented Jun 11, 2014

bpinto commented Jun 11, 2014

rominf commented Jun 12, 2014

bpinto commented Jul 16, 2014

bpinto commented Aug 15, 2014

bpinto commented Aug 15, 2014

rominf commented Aug 15, 2014

rominf commented Aug 15, 2014

bpinto commented Aug 15, 2014

rominf commented Aug 15, 2014

rominf commented Aug 15, 2014

terlar commented Aug 16, 2014

bpinto commented Nov 20, 2014

rominf commented Nov 20, 2014

bpinto commented Nov 20, 2014

rominf commented Nov 20, 2014

rominf commented Nov 25, 2014

rominf commented Nov 25, 2014

bpinto commented Nov 26, 2014

terlar commented Nov 26, 2014

rominf commented Nov 26, 2014

bpinto commented Nov 28, 2014

rominf commented Nov 28, 2014