Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omf install removes symlinked bundle #303

Closed
andrewrynhard opened this issue Apr 19, 2016 · 2 comments
Closed

omf install removes symlinked bundle #303

andrewrynhard opened this issue Apr 19, 2016 · 2 comments

Comments

@andrewrynhard
Copy link
Contributor

I use a dotfile manager that symlinks $OMF_CONFIG/bundle. When I run omf install <plugin-name> the link gets replaced by a file. Many dotfile managers use symlinks. It would be useful to change this behavior.

@andrewrynhard andrewrynhard changed the title omg install removes symlinked bundle omf install removes symlinked bundle Apr 19, 2016
@andrewrynhard andrewrynhard changed the title omf install removes symlinked bundle omf install removes symlinked bundle Apr 19, 2016
@andrewrynhard andrewrynhard changed the title omf install removes symlinked bundle omf install removes symlinked bundle Apr 19, 2016
@oranja
Copy link
Contributor

oranja commented Apr 19, 2016

Thank you for this vital feedback.

My estimate is that the culprit lies in omf.bundle.add (the sort call).
This brings the question: Do we really need the bundle file sorted at all times? (I never understood the motive)

@andrewrynhard: we'll try to get to it soon, but feel free to suggest a fix for this in a PR yourself.

@andrewrynhard
Copy link
Contributor Author

Thanks! I will try to take a stab at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants