Fix #303 #305
Merged
Fix #303 #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,10 @@ | |||
| function omf.bundle.add -a type name_or_url | |||
| set -l bundle $OMF_CONFIG/bundle | |||
| if test -h $OMF_CONFIG/bundle | |||
There was a problem hiding this comment.
I'm looking both at the fish website and the man page, and -h is undocumented. Maybe -L would make it easier for people to understand what it's doing?
|
I added some small comments on the code, but overall this is even better than what I had in mind. |
|
Let me know if I can change anything else. |
|
👍 Looking good. |
|
Cool! I like this fix, very clean and simple. Thanks for implementing!! |
|
Elegant solution. 👍 |
|
I think we can merge it 👍 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to set
bundleappropriately in the case that it is a symlink.