Fix theme key bindings #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested it successfully. All checks have passed. Thank you. |
derekstavis
force-pushed
the
fix-theme-key-bindings
branch
from
76b1d72
to
e45a6fe
Compare
derekstavis
force-pushed
the
fix-theme-key-bindings
branch
from
e45a6fe
to
c812242
Compare
|
Thanks for the testing @tannhuber |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the way themes key bindings are treated.
Previous to this PR all installed themes key bindings would be loaded. This PR makes startup code load only current theme key bindings, when existent.
Also, previously, key bindings wouldn't be reloaded on theme change. This reloads key bindings file when it's found on the theme.
@tannhuber, I see your themes use key bindings. Would you like to help us test this PR?
To enable automatic key binding load on themes, move all
bindcalls tokey_bindings.fishfile in theme's repository root directory.This PR should make
omf t dangerous; omf t budspencerusebudspencerkey bindings.