Add branch information for install and update package #685
Conversation
|
oh-my-fish/packages-main#82 is related repo pull request |
|
Is this PR dead? Branch support would be helpful when testing plugin PRs locally. |
|
This has a bunch of unadressed comments, so those should either be handled by the author, handled by whoever merges it or this should be closed. |
|
Sorry, I have forgotten this PR for a while 😿 . I will follow these comments and modify this PR soon 🚀 . |
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
YangKeao
force-pushed
the
add-branch-information
branch
from
62d9c9e
to
8eff483
Compare
|
Could this please be merged and released? This would really help me further develop some plugins that I'm working on :) If this is waiting for testing, let me know :) Happy to test. |
|
Cool, thanks! |
|
I think you're close - but I get an error when using $ omf update
Oh My Fish is up to date.
You are now using Oh My Fish version 7-44-gd428b72.
Updating https://github.com/oh-my-fish/packages-main master... Done!
fatal: couldn't find remote ref refs/heads/master
Could not update fish-functions.
bobthefish is already up-to-date.
default is already up-to-date. |
|
well... I see the PR covers a bit of a different but related issue - I created a separate PR instead: |
Somewhat related to oh-my-fish#905 and oh-my-fish#685
Somewhat related to oh-my-fish#905 and oh-my-fish#685
See #678.
Find branch information in the repository first and then clone (or pull). If package doesn't have a branch attribute,
masteris used as the default branch.Maybe more test is needed for it (especially for function
omf.repo.pull). I only test them on several packages and themes and it works well, but I don't know wethear this project has some unit tests to go through.