Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support installing repo from URL with non-master branch #908

Merged
merged 1 commit into from
Oct 2, 2022

Conversation

tennox
Copy link
Contributor

@tennox tennox commented Jun 20, 2022

Somewhat related to #905 and #685, but by use-case is not a package in packages-main repo, but a GitLab repo, for which install currently works fine, but omf update results in this:
(on omf channel dev)

Oh My Fish is up to date.
You are now using Oh My Fish version 7-44-gd428b72.
Updating https://github.com/oh-my-fish/packages-main master... Done!
fatal: couldn't find remote ref refs/heads/master
Could not update fish-functions.
bobthefish is already up-to-date.
default is already up-to-date.

While debugging I found set branch "master" in pkg/omf/functions/repo/omf.repo.pull.fish and changed it to use current branch as fallback/default an old convention

I tried thinking of all the edge-cases you're covering, but not sure if I understood correctly.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing tests pass locally with my changes

@tennox
Copy link
Contributor Author

tennox commented Jun 26, 2022

For anyone who wants to try:

omf channel dev
cd $OMF_PATH
git remote set-url origin https://github.com/tennox/oh-my-fish.git
git pull origin master
omf update

Copy link
Member

@scorphus scorphus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tennox!

@scorphus scorphus merged commit 90f875e into oh-my-fish:master Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants