Simplify and fix right prompt #20
Conversation
|
@sn0cr can you merge this? I've also added this caveat to the README. |
|
Hey @olbrew I will have a look at your pull request and merge if it works for me. Thanks for the ping. |
| @@ -26,7 +27,6 @@ For Mac users, I highly recommend iTerm 2 + Solarized Dark | |||
| * Current virtualenv (Python) | |||
| You will probably want to disable the default virtualenv prompt. Add to your [`init.fish`](https://github.com/oh-my-fish/oh-my-fish#dotfiles): | |||
| `set --export VIRTUAL_ENV_DISABLE_PROMPT 1` | |||
| * Indicate vi mode. (If you've set `fish_vi_mode` in your config and don't like the ugly left prompt indicator you can solve this by replacing it with `set -g fish_key_bindings fish_vi_key_bindings` and then removing the `if set -q __fish_vi_mode` check at the bottom of the `fish_right_prompt.fish`) | |||
|
|
|||
| * Indicate vi mode. You will probably want to disable the default vi mode prompt. Add to your [`init.fish`](https://github.com/oh-my-fish/oh-my-fish#dotfiles): `function fish_mode_prompt; end function` | |||
There was a problem hiding this comment.
The command should be function fish_mode_prompt; end. There's no end function 😛
|
The best thing to do if you'd like the theme to automatically remove the left vi indicator is to define an empty |
Default unset state of `theme_host_hostname` will still mean auto-mode, but explicit `no` value will force to always show a hostname.
|
@derekstavis That's indeed even better. I've added it to the right prompt. That seems better than creating a new file just for the purpose of defining an empty function. I've also squashed the commits to have a cleaner history. |
Rewrites the right prompt it with native fish-shell functions, fixes the coloring issue seen before and adds a new check for the vi mode used from fishv v2.3 onward so it is only shown when vi mode is enabled.
|
Sorry that I'm replying that late. |
|
Yep, should be ready to go. I use it myself and it works against the latest version 👍. |
|
Thank you very much @olbrew for your contribution and @derekstavis for the help. |
The right prompt shows a Vi mode indicator.
This commit rewrites it with native fish-shell functions, fixes the coloring
issue seen before and adds a new check for the vi mode used from fish v2.3
onward so it is only shown when vi mode is enabled.
This is the follow up pull request as discussed in #19