Merge pull request #18 from rbmrclo/refactor/pull-requests-ignorable

Improve pattern matching of title for ignorable PRs

src/PullRequests.js

@@ -12,9 +12,10 @@ class PullRequests {
   }
 
   isIgnorable(pr) {
-    const ignoreWords = ['wip', 'dont merge', 'dontmerge', 'donotmerge']
+    const ignoreWords = ['wip', 'dontmerge', 'donotmerge']
     const regex = new RegExp(`(${ignoreWords.join('|')})`, 'i')
-    return !!pr.title.match(regex)
+    const sanitizedTitle = pr.title.replace(/'|\s+/g, '')
+    return !!sanitizedTitle.match(regex)
   }
 
   belongsToOwner(pr) {

test/PullRequests.test.js

@@ -0,0 +1,16 @@
+const PullRequests = require('../src/PullRequests')
+
+test('.isIgnorable(pr) returns true with matched strings', () => {
+  const pullRequest = new PullRequests()
+  const pullRequests = [
+    { title: "Dont merge - this is a PR title" },
+    { title: "Don't merge - this is a PR title" },
+    { title: "Do not merge - this is a PR title" },
+    { title: "[DO NOT MERGE] - this is a PR title" },
+    { title: "WIP - this is a PR title" },
+  ]
+
+  for (const pr of pullRequests) {
+    expect(pullRequest.isIgnorable(pr)).toBeTruthy()
+  }
+})