Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to fullscreen support in Camera Feed #8118

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Jul 5, 2024

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner July 5, 2024 13:41
Copy link

vercel bot commented Jul 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2024 1:41pm

Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 8fae7b3
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6687f7f3e11c9d0008389c17
😎 Deploy Preview https://deploy-preview-8118--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Jul 5, 2024

Passing run #2816 ↗︎

0 126 0 0 Flakiness 0

Details:

Improvements to fullscreen support in Camera Feed
Project: CARE Commit: 8fae7b3671
Status: Passed Duration: 02:53 💡
Started: Jul 5, 2024 1:45 PM Ended: Jul 5, 2024 1:48 PM

Review all test suite changes for PR #8118 ↗︎

@nihal467
Copy link
Member

nihal467 commented Jul 8, 2024

testing in multiple devices using browserstack

  • check in laptop
  • android phone
  • iPhone

@nihal467
Copy link
Member

nihal467 commented Jul 9, 2024

android test was failing in browser stack, but successful running in a real device via khavins helps. so LGTM

@khavinshankar khavinshankar merged commit fe44dd1 into develop Jul 9, 2024
71 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix/8085-camera-feed-fullscreen-view-enhancements branch July 9, 2024 17:19
Copy link

github-actions bot commented Jul 9, 2024

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancements to fullscreen view in mobiles for camera feed
3 participants