Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-pdf; pdfjs worker; Fixes for i18n #8395

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Update react-pdf; pdfjs worker; Fixes for i18n #8395

merged 2 commits into from
Aug 22, 2024

Conversation

gigincg
Copy link
Member

@gigincg gigincg commented Aug 22, 2024

Proposed Changes

  • Fixes #issue_number
  • Update react-pdf Package
  • Update pdfjs worker for react-pdf
  • Add i18n for few strings

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@gigincg gigincg requested a review from a team as a code owner August 22, 2024 10:14
Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 10:16am

Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3cc9902
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c70fb4b97ea200087508bc
😎 Deploy Preview https://deploy-preview-8395--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Aug 22, 2024



Test summary

126 0 0 0


Run details

Project CARE
Status Passed
Commit 3cc9902
Started Aug 22, 2024 10:20 AM
Ended Aug 22, 2024 10:23 AM
Duration 03:30 💡
OS Linux Ubuntu -
Browser Chrome 128

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@nihal467
Copy link
Member

image

pdf file previewer is failing to load the below PDF

discharge_summary-Test Apri-2024-08-21 11_01_16.652021+00_00.pdf

@gigincg gigincg merged commit 90ee1b5 into develop Aug 22, 2024
62 checks passed
@gigincg gigincg deleted the pdf_preview branch August 22, 2024 16:58
Copy link

@gigincg Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

UdaySagar-Git pushed a commit to UdaySagar-Git/care_fe that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDF Preview is not working in file upload component
3 participants