feat: Add proper support for ES modules via a Rollup build step #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdubroy
commented
Jan 8, 2022
| @@ -4,7 +4,7 @@ | |||
| // Imports | |||
| // -------------------------------------------------------------------- | |||
|
|
|||
| const pexprs = require('./pexprs'); | |||
| const pexprs = require('./pexprs-main'); | |||
There was a problem hiding this comment.
Had to add this to avoid a warning about circular dependencies from Rollup.
|
@megabuz: Please take a look and let me know if this looks like a reasonable approach to you. |
Closed
|
Published this as |
|
Going to merge this now since it seems to fix the problem. Happy to address anything else in a follow-up. |
|
Thank you! I'm glad ohm receives better ESM support. It's working, nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #185. Now that Ohm can be built with Rollup (see #344), we can ship a proper ES module via a Rollup build step.