-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make deferred init works for rollup #344
Conversation
I found several similar problems, I'm trying to fix them |
So upon further testing I found that any |
@megabuz Thanks for taking this on! Is this PR ready for review? It seems to contain some unrelated changes. Can you trying rebasing your branch onto master? |
@pdubroy it is ready to review. |
@megabuz Great! And sorry — my mistake, at a quick glance I thought some of these changes were related to something else. Thanks again, and I'll try to review this in the next day or two. |
Awesome, thanks for doing this! It looked good to me so I've gone ahead and merged it. |
Just published v16.1.1 which contains these changes. |
I've tried to use
ohm-js
with rollup and I've faced the issue of circular dependency inpexprs.js
.Based on specification all imports should be evaluated prior to the body of module doing the importing, so in case when
pexprs
requires bunch of extensions, e.g.pexprs-allowsSkippingPrecedingSpace
, rollup includes these extensions in the final bundle beforepexprs
. However they depend onpexprs
and I'm receiving error similar to #185 (comment)In this PR I moved body of
pexprs
to separate file. It should make rollup module ordering work correctly.