Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Update nomenclature before we get popular. #7

Closed
Leopere opened this issue Jul 17, 2019 · 19 comments · Fixed by #10
Closed

Update nomenclature before we get popular. #7

Leopere opened this issue Jul 17, 2019 · 19 comments · Fixed by #10
Labels
hacktoberfest 2019's Hacktoberfest label.

Comments

@Leopere
Copy link
Contributor

Leopere commented Jul 17, 2019

Ideally, we should be avoiding getting stuck with TellForm names in any of the examples or database structure long term so if we can sift through with a find & replace function and remove everything without removing direct references to the upstream.

@Leopere Leopere changed the title Fix nomenclature before we get popular. Update nomenclature before we get popular. Jul 17, 2019
@wodka wodka closed this as completed in #10 Jul 18, 2019
@kiwicopple
Copy link

I don't know if this is worth opening another issue, but does this mean that this fork is ready to use? If I'm starting now, should I use ohmyform or tellform?

This looks cool btw!

@wodka
Copy link
Contributor

wodka commented Aug 21, 2019

@kiwicopple you should definitely use OhMyForm.

@kiwicopple
Copy link

Thanks @wodka 👍

@Leopere
Copy link
Contributor Author

Leopere commented Aug 22, 2019

@kiwicopple how did you generate your GitHub photo btw?

@kiwicopple
Copy link

@Leopere I used the Primitive software by Michael Fogleman:
https://www.michaelfogleman.com/#primitive

Probably the only thing I have used it for, but his projects are all so great I wanted to support him by purchasing something from him

@karser
Copy link

karser commented Sep 2, 2019

Looks like this is related
image

@wodka
Copy link
Contributor

wodka commented Sep 2, 2019

thx @karser will change this

@karser
Copy link

karser commented Sep 2, 2019

I guess it needs massive replacement

image

image

Also there is sentry dsn points to tellform: Raven.config('https://825fefd6b4ed4a4da199c1b832ca845c@sentry.tellform.com/2')

@Leopere Leopere reopened this Sep 2, 2019
@Leopere
Copy link
Contributor Author

Leopere commented Sep 2, 2019

We can re-open this until the rest of these things are cleaned up. I imagine the next big release from @wodka will be able to close this off.

@Leopere Leopere added the hacktoberfest 2019's Hacktoberfest label. label Sep 2, 2019
@wodka
Copy link
Contributor

wodka commented Sep 10, 2019

just checked in my branch - I cannot find the references there - will also check the next build if this is still existing

@vickywane
Copy link

Hi ,

I would like to make some contributions here as part of the hacktoberfest.

I read the issue description but couldnt understand it clearly.

Do you mind explaining the objective @Leopere ?

@Leopere
Copy link
Contributor Author

Leopere commented Oct 2, 2019

Hey @vickywane this one should be pretty simple for the most part we just need to eliminate naming references to TellForm in the code as we're attempting to eventually replace the entire codebase with something a bit more modern. If you find any instances or references of TellForm that's useful to us.

@vickywane
Copy link

Alright . So i'll just make a PR stating where i found them and snapshots .

@vickywane
Copy link

I created this tellform/tellform#349 .
Is this a good starting point ?

@wodka @Leopere

@wodka
Copy link
Contributor

wodka commented Oct 4, 2019

@vickywane Not really, we want to remove all remaining references of tellform, because ohmyform is the way to go forward.

The best way is to start it locally and check at least the screenshots from this thread to remove tellform

@vickywane
Copy link

Great.

It seems i didn't understand the task clearly .

I'll try run the project locally

@Leopere
Copy link
Contributor Author

Leopere commented Oct 5, 2019 via email

@vickywane
Copy link

Alright .
Am willing to spend some more time to contributing to that .

I had some troubles trying to run the docker images locally yesterday .
Would it be ideal to run some sort of text search operation on the code-base ?

@Leopere
Copy link
Contributor Author

Leopere commented Oct 8, 2019 via email

@wodka wodka closed this as completed Jun 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hacktoberfest 2019's Hacktoberfest label.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants