-
-
Notifications
You must be signed in to change notification settings - Fork 434
-
-
Notifications
You must be signed in to change notification settings - Fork 434
Update nomenclature before we get popular. #7
Comments
I don't know if this is worth opening another issue, but does this mean that this fork is ready to use? If I'm starting now, should I use ohmyform or tellform? This looks cool btw! |
@kiwicopple you should definitely use OhMyForm. |
Thanks @wodka 👍 |
@kiwicopple how did you generate your GitHub photo btw? |
@Leopere I used the Primitive software by Michael Fogleman: Probably the only thing I have used it for, but his projects are all so great I wanted to support him by purchasing something from him |
thx @karser will change this |
We can re-open this until the rest of these things are cleaned up. I imagine the next big release from @wodka will be able to close this off. |
just checked in my branch - I cannot find the references there - will also check the next build if this is still existing |
Hi , I would like to make some contributions here as part of the hacktoberfest. I read the issue description but couldnt understand it clearly. Do you mind explaining the objective @Leopere ? |
Hey @vickywane this one should be pretty simple for the most part we just need to eliminate naming references to TellForm in the code as we're attempting to eventually replace the entire codebase with something a bit more modern. If you find any instances or references of TellForm that's useful to us. |
Alright . So i'll just make a PR stating where i found them and snapshots . |
I created this tellform/tellform#349 . |
@vickywane Not really, we want to remove all remaining references of tellform, because ohmyform is the way to go forward. The best way is to start it locally and check at least the screenshots from this thread to remove tellform |
Great. It seems i didn't understand the task clearly . I'll try run the project locally |
That’s no problem at all I appreciate the efforts! Technically that PR does
work for Hacktoberfest however we are looking to find the instances of the
word TellForm in the OhMyForm codebase that weren’t caught before in our
previous removal attempt. I still want to leave credit to it but this
codebase will be very different in the future from TellForm.
…On Fri, Oct 4, 2019 at 10:21 PM victory ***@***.***> wrote:
Great.
It seems i didn't understand the task clearly .
I'll try run the project locally
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7?email_source=notifications&email_token=AAIE2VSWVN4BKTE56S5REDTQM724NA5CNFSM4IEVRCDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEANIGAA#issuecomment-538608384>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIE2VXON6FKJK44ZR733ZTQM724NANCNFSM4IEVRCDA>
.
|
Alright . I had some troubles trying to run the docker images locally yesterday . |
Do whatever seems appropriate just make sure that you test your build and
that there are no regressions from your changes.
…On Sun, Oct 6, 2019 at 7:15 AM victory ***@***.***> wrote:
Alright .
Am willing to spend some more time to contributing to that .
I had some troubles trying to run the docker images locally yesterday .
Would it be ideal to run some sort of text search operation on the
code-base ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7?email_source=notifications&email_token=AAIE2VW2QJWSWLIYUQLFFSTQNHCE5A5CNFSM4IEVRCDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAOHSHY#issuecomment-538736927>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIE2VTXPJ4VF4H6M42UVRLQNHCE5ANCNFSM4IEVRCDA>
.
|
Ideally, we should be avoiding getting stuck with TellForm names in any of the examples or database structure long term so if we can sift through with a find & replace function and remove everything without removing direct references to the upstream.
The text was updated successfully, but these errors were encountered: