Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider spring cleanup of non-essentials from lib/ #3614

Closed
N4M3Z opened this issue Feb 20, 2015 · 4 comments · Fixed by #3986
Closed

Consider spring cleanup of non-essentials from lib/ #3614

N4M3Z opened this issue Feb 20, 2015 · 4 comments · Fixed by #3986

Comments

@N4M3Z
Copy link

N4M3Z commented Feb 20, 2015

Currently, there is a large number of non-essential scripts in the default lib/ directory (e.g. bzr.zsh). While I understand that most of these only define functions, I see simply no reason to load them. Please consider making these into plugins and keep lib/ folder clutter-free.

At this point, it is necessary to keep an empty file of the same name in custom/ for each script provided in lib/ so they are not loaded automatically. I am running oh-my-zsh on multiple machines and some do not support to full feature set used (e.g. url-quote-magic) making this use case quite inconvenient.
@alienth
Copy link

alienth commented Mar 12, 2015

+1. Not being able to ignore these libs without hacks feels ugly.

For my own setup, I moved non-essentials libs to plugins and it works quite nicely. If I want the functionality from those libs, I can just load them as plugins: alienth@879bc57

@N4M3Z
Copy link
Author

N4M3Z commented Mar 12, 2015

Due to lack of interest, I actually moved to zgen (https://github.com/tarjoilija/zgen/blob/master/zgen.zsh) plugin manager and currently only use oh-my-zsh as a source of plugins.

@ncanceill
Copy link
Contributor

Hi, and thanks for contributing.

Concerning url-quote-magic and other potential support issues, we can either add a setting or consider doing an automated check at init time.

Concerning "non-essential scripts", you mention bzr.zsh and maybe also mean nvm.zsh and prompt_info_functions.zsh. These define functions to be used in themes, in order to provide various features, usually enhancing the custom prompt.

Granted, bzr_prompt_info is only used by the frisk theme, so it is arguable that it should be moved from lib/ into it.

However, most functions like that in lib/ are actually shared by several plugins or themes, and moving them over there would require duplicating them.

@N4M3Z
Copy link
Author

N4M3Z commented Apr 8, 2015

On compatibility: Yes, that would be a good solution to the problem.

On non-essential scripts: My objection to the oh-my-zsh approach is that unless I am using a given theme, some files from the lib folder are sourced for no reason. In my opinion, it should be the theme which sources the required libraries by itself. But I guess changing the behaviour would require a larger consensus.

In any case, I am currently using zgen and have isolated from the oh-my-zsh loading system completely.

@evilhamsterman evilhamsterman mentioned this issue Jun 10, 2015
Merged
steshaw pushed a commit to steshaw/oh-my-zsh that referenced this issue Jun 16, 2015
@evilhamsterman @steshaw
Only load url-quote-magic if it is available.
a6cd630 
Partially fixes ohmyzsh#3614
Spirotot pushed a commit to Spirotot/oh-my-zsh that referenced this issue Jun 27, 2015
@evilhamsterman
Only load url-quote-magic if it is available.
4a23e5e 
Partially fixes ohmyzsh#3614
jbontik pushed a commit to jbontik/oh-my-zsh that referenced this issue Jul 19, 2015
@evilhamsterman @jbontik
Only load url-quote-magic if it is available.
87687bb 
Partially fixes ohmyzsh#3614
torbjoernk added a commit to torbjoernk/oh-my-zsh that referenced this issue Jul 25, 2015
@torbjoernk
Merge branch 'master' into theme-tklatt
c56b0f1 
* master:
  virtualenvwrapper: Replace "realpath" with portable zsh-native `:A` and `:h` modifiers
  Plugin now uses completion script from docker-compose repo.
  git plugin: fix ggl to avoid empty string see ohmyzsh#2790 (comment)
  Fix plugin/git ggpull and ggpush backward compatibility
  Fix merge conflict for jira-prefix and jira add comment
  Add missing space causing parse error.
  Fixed odd chars on mac for agnoster theme
  Add mix-fast plugin (similar to rake-fast)
  Update _docker
  Adding quotes to git completion discovery path
  A paver (Python build and configuration utility) plugin
  Revert "Added migration notification for rails plugin"
  Added github in web_search plugin.
  last-working-dir working with spaces in dirnames
  use local options to set no_equals before sourcing bash completion script
  git plugin: new/changed aliases gaa was brought back by popular demand — see ohmyzsh#3535 gap was replaced with gapa — see ohmyzsh#3682 gdc was replaced with gdca — see ohmyzsh#3977
  Add reference to bundler plugin issue in README
  Add `leaves` command to `brew` completion
  remove trash command from osx plugin
  Added README.md file for ForkLift plugin
  Added README.md file for atom plugin
  Added README.md file
  Fix README.md for sst command
  Plugins: vi-mode: Add first README file
  Plugins: archlinux - add basic README.
  Plugins: archlinux - use command -v in favor of which
  Plugins: apache2-macports - add README
  Added references to the `external themes` wiki page.
  git plugin: fix ggpnp when called without argument also allow multiple arguments for ggp and ggl aliases
  * Added header with help and information * Moved git information to left prompt, with   support for:     * +ZSH_THEME_GIT_PROMPT_UNTRACKED, MODIFIED,     STASHED, ADDED, UPSTREAM STATUS     (if applicable) * Removed right prompt * Refactored following Google's guidelines for   scripts [ http://goo.gl/oJSXH2 ]     * Using local variables where applicable
  Update Mix complition upto 1.0.4
  Update aliases in laravel5.plugin.zsh file
  Update taskwarrior.plugin.zsh
  Renamed 'ss' alias to 'sstat' (to avoid collision with /bin/ss).
  Fixed typo in README
  Update bgnotify.plugin.zsh
  fix typo
  adb: add more commands
  Update README.markdown
  Fixed jump pluging to display the right mark name on 'mark . '
  Added README for mercurial plugin
  Add git to prerequisites
  add help link to install zsh
  sublime: Make subl a function so it can be called from functions in other modules
  Added support for detecting Sublime Text 3 on Arch Linux
  Update history-substring-search README
  Added the tugboat autocompletion plugin
  git plugin: make b local in gg* functions because it leaked, and led to ohmyzsh#3991
  git plugin: fix error msg in gwip alias because git rm will fail when no files were deleted
  git plugin: global var for git command due to issues like ohmyzsh#3962 until a proper plugin-loading system is implemented
  git plugin: bring back olg gg aliases by popular demand, see ohmyzsh#3972
  More run and create options
  Only load url-quote-magic if it is available. Partially fixes ohmyzsh#3614
  Disable globbing when executing `zeus rake` aliases to enable use of square brackets without escaping
  Add git_prompt_behind and git_prompt_exists
  add kitchen completion plugin from @petere
  Added a possibility to display the remote branch and the number of commits you are ahead or behind
  Fix homebrew directory in aws plugin.
  Recognize comments by default.
  Move custon *.zsh file sourcing up so that they can load plugins and other things that come after.
  added comment functionality
  Improved the `_git_time_since_commit` function.
  Remove docker insert command
  Add README for httpie plugin
  Fix typo in $VCS_CLEAN_COLOR in adben theme
  Grep bug in Agnoster
  generate with 'pod --completion-script' /cc thx to @ajmccall
  updated the command list to the latest cocoapod version (0.33.0)
  No input for Update Check defaults to Yes
  Add rdrs method to reset the database(s)
  Set AWS_PROFILE and use existing RPROMPT
  Add new boot2docker options
  Add installation instructions to README
  Round 3 of batch-closing obsolete issues
  Respect $ZSH_CACHE_DIR when creating fasd's cache
  Create new aliases for homebrew plugin
  Add sublime text 3 paths to check list
  Don't leak extendedglob to global environment.
  Detect the .venv in any parent directory of the current directory
  Add CakePHP3 plugin
  Differing upgrade and safe-upgrade
  Many updates to git plugin (see ohmyzsh#2790)
  Use $EDITOR
  Fix 'chsh' by checking '/etc/shells' instead of using 'which'
  Add alias of bundle clean
  Added aliases for docker compose
  add markdown extension to README
  Add readme and add new alias cfpc: paste+compile+copy
  Update template zshrc with HYPHEN_INSENSITIVE
  typofix
  Add coffeescript aliases: cf, cfc, cfp
  Add hyphen insensitivity
  Fixing some issues where show repeated weird values, and fixed commands that need the container autocomplete without being running, like start, now it autocompletes showing all the containers so you can start without knowing the right name
  Fix minimal.zsh-theme's check for in_svn and add support for mercurial
  Add autocomplete for frontend-search
  Fixes gradle autocomplete. Regex did not include subproject tasks before.
  fix stackoverflow url in search
  Use the newest Vundle commands
  Add stackoverflow link
  Fixed Typo.
  Use camelCase for npm aliases
  Fix echo nothing if $SHORT_HOST doesn't exist.
  Add .ipsw to the extract plugin.
  Minor cosmetic fix to minimal theme
  [boot2docker plugin] Initial version
  fix paclist() for non-english locales
  gitfast: back-port prompt fix
  gitfast: update to upstream v1.9.2
sparrc pushed a commit to sparrc/oh-my-zsh that referenced this issue Jul 27, 2015
@evilhamsterman @sparrc
Only load url-quote-magic if it is available.
638ea72 
Partially fixes ohmyzsh#3614
DerToti pushed a commit to DerToti/oh-my-zsh that referenced this issue Jul 29, 2015
@evilhamsterman @DerToti
Only load url-quote-magic if it is available.
346171a 
Partially fixes ohmyzsh#3614
kirb pushed a commit to kirb/oh-my-zsh that referenced this issue Aug 23, 2015
@evilhamsterman @kirb
Only load url-quote-magic if it is available.
2deb34a 
Partially fixes ohmyzsh#3614
ChristianLohmann pushed a commit to ChristianLohmann/oh-my-zsh that referenced this issue Aug 31, 2015
@evilhamsterman @ChristianLohmann
Only load url-quote-magic if it is available.
8419db0 
Partially fixes ohmyzsh#3614
inutano pushed a commit to inutano/oh-my-zsh that referenced this issue Oct 19, 2015
@evilhamsterman @inutano
Only load url-quote-magic if it is available.
02ceb65 
Partially fixes ohmyzsh#3614
tmitchell pushed a commit to tmitchell/oh-my-zsh that referenced this issue Mar 31, 2016
@evilhamsterman
Only load url-quote-magic if it is available.
a402f98 
Partially fixes ohmyzsh#3614
NobbZ pushed a commit to NobbZ/oh-my-zsh that referenced this issue May 15, 2016
@evilhamsterman @NobbZ
Only load url-quote-magic if it is available.
cbc1713 
Partially fixes ohmyzsh#3614
DennisDenuto pushed a commit to DennisDenuto/oh-my-zsh that referenced this issue Oct 29, 2016
@evilhamsterman @DennisDenuto
Only load url-quote-magic if it is available.
1a18f12 
Partially fixes ohmyzsh#3614
fforw pushed a commit to fforw/oh-my-zsh that referenced this issue Feb 21, 2017
@evilhamsterman @fforw
Only load url-quote-magic if it is available.
7ab7b66 
Partially fixes ohmyzsh#3614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only load url-quote-magic if it is available.
3 participants
@alienth @ncanceill @N4M3Z