Use local command properly in plugins/git/git.plugin.zsh

[devunt]

zsh local command will print out pair or variable name and value if it has value. [1]

What supposed to happen is:

What actually happend is:

[1] http://zsh.sourceforge.net/Doc/Release/Shell-Builtin-Commands.html

[devunt]

CC: @ncanceill

[apjanke]

The real issue is that this code is using local outside a function call. When used inside a function call, local <varname> does not produce output. That local git_cmd that's sitting outside a function doesn't actually localize the variable: zsh variables are dynamically, not lexically scoped. You may as well just remove that local: the way plugins are loaded now, it's not doing anything, and if the plugin were loaded from inside a function call, local-izing it would probably break things.

[devunt]

I know that the bash local command can't be used from the outside of function, but is the zsh same?

[apjanke]

Local variables in zsh work the same as local variables in bash. But the local command in zsh is slightly different: you can call it outside a function. It just probably won't do what you want. Basically, you should only use local variables in zsh the same places where you would use them in bash. Inside functions, or in code that's only going to get called from inside a function.

[apjanke]

The presence of this local may be causing #3963. The error message sounds like it's related.

[ncanceill]

@devunt would you be so kind as to fetch my fork and cherry-pick 6c29041 to see if it fixes your issue?

[devunt]

@ncanceill it works like a charm.

[ncanceill]

Awesome! this will be merged as soon as the other issues are solved.

[devunt]

Then should I close this pr now?

[ncanceill]

You can, but even if you omit to do so, this will close when #3990 gets merged.