Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(1password): fix comments to follow code #10634

Merged
merged 1 commit into from
Jan 28, 2022
Merged

chore(1password): fix comments to follow code #10634

merged 1 commit into from
Jan 28, 2022

Conversation

gheritarish
Copy link
Contributor

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.

Changes:

  • Originally intended to be a code change to follow the comments, I then noticed the README and the code were the same; I decided to update the comments instead, so someone reading the code wouldn't be surprised as I was when I tried to understand it.

Other comments:

  • As I said, it's purely for people reading the code, feel free to refuse my PR if you don't find it that useful on its own!

@gheritarish
chore(1password): Fix code comments to follow code
0b761d9 
The comments of the code indicate that a one-time password is copied
after 5 seconds and that the clipboard is cleared after 10 seconds.
However, the README and the code indicate times of respectively 10 and
20 seconds.
Updating the comments to not be confusing for people reading the code.
@ohmyzsh ohmyzsh bot added the Area: plugin Issue or PR related to a plugin label Jan 28, 2022
@mcornella mcornella changed the title chore(1password): Fix code comments to follow code chore(1password): fix comments to follow code Jan 28, 2022
@mcornella mcornella merged commit 11a87ea into ohmyzsh:master Jan 28, 2022
@mcornella
Copy link
Member

Thanks!

lesterchan added a commit to lesterchan/oh-my-zsh that referenced this pull request Feb 5, 2022
@lesterchan
Merge remote-tracking branch 'upstream/master'
ca5e350 
* upstream/master: (41 commits)
  Introducing the ANSI logo graphic
  feat(yarn): add setting to disable adding global dir to `$PATH` (ohmyzsh#10642)
  fix(cli): allow `omz` commands to be used in a script (ohmyzsh#10645)
  feat(multipass): add plugin for multipass (ohmyzsh#10140)
  refactor(zsh_reload)!: remove deprecated plugin
  chore: update copyright year
  refactor(django): remove deprecated `django` plugin
  style(init): use consistent code style in init script (ohmyzsh#10601)
  refactor(installer): use POSIX-standard's `id -u -n` to define `$USER`
  chore(1password): fix comments to follow code (ohmyzsh#10634)
  fix(gitfast): update to git-completion 1.3.6 (ohmyzsh#10633)
  fix(changelog): don't show changelog with only ignored type commits
  style(rkj-repos): change `white` to `default` to support light color schemes (ohmyzsh#6195)
  fix(tmux): use `$ZSH_TMUX_CONFIG` setting in tmuxconf alias
  fix(ys): fix `$VIRTUAL_ENV` check if `nounset` is enabled (ohmyzsh#9915)
  fix(installer): avoid `git clone -c` to support git v1.7.1 (ohmyzsh#10621)
  fix(npx)!: detect new `npx` versions and fail gracefully (ohmyzsh#10452)
  style(updater): silence `git pull` output and show errors in English
  feat(postgres): support Homebrew for Apple Silicon (ohmyzsh#10618)
  fix(cli): make sure to run `zsh` command if an alias exists (ohmyzsh#9737)
  ...
D0n9X1n pushed a commit to MOSconfig/oh-my-zsh that referenced this pull request Feb 16, 2022
@gheritarish @D0n9X1n
chore(1password): fix comments to follow code (ohmyzsh#10634)
8add310
amkirby pushed a commit to amkirby/oh-my-zsh that referenced this pull request Mar 9, 2022
@gheritarish @amkirby
chore(1password): fix comments to follow code (ohmyzsh#10634)
5a0b381
cmoore pushed a commit to cmoore/oh-my-zsh that referenced this pull request Apr 28, 2022
@gheritarish @cmoore
chore(1password): fix comments to follow code (ohmyzsh#10634)
c6b0391
FelixDombek pushed a commit to FelixDombek/ohmyzsh that referenced this pull request May 18, 2022
@gheritarish @FelixDombek-TomTom
chore(1password): fix comments to follow code (ohmyzsh#10634)
a3ceb74
Daddelhai pushed a commit to Daddelhai/ohmyzsh that referenced this pull request Jul 4, 2022
@gheritarish @Daddelhai
chore(1password): fix comments to follow code (ohmyzsh#10634)
557c821
kis87988 pushed a commit to kis87988/ohmyzsh that referenced this pull request Jul 5, 2022
@gheritarish @kis87988
chore(1password): fix comments to follow code (ohmyzsh#10634)
b291201
tekniklr pushed a commit to tekniklr/oh-my-zsh that referenced this pull request Sep 6, 2022
@gheritarish
chore(1password): fix comments to follow code (ohmyzsh#10634)
530c238
rahdjoudj pushed a commit to rahdjoudj/ohmyzsh that referenced this pull request Nov 3, 2022
@gheritarish @reda-sj
chore(1password): fix comments to follow code (ohmyzsh#10634)
e18f9aa
dilfish pushed a commit to dilfish/oh-my-zsh that referenced this pull request Feb 16, 2023
@gheritarish
chore(1password): fix comments to follow code (ohmyzsh#10634)
38525a2
nbaronov pushed a commit to nbaronov/oh-my-zsh that referenced this pull request Aug 3, 2023
@gheritarish @nbaronov
chore(1password): fix comments to follow code (ohmyzsh#10634)
e216939
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: plugin Issue or PR related to a plugin
Projects
Main project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gheritarish @mcornella