Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(yarn): add setting to disable adding global dir to $PATH #10642

Merged
merged 1 commit into from Feb 3, 2022
Merged

feat(yarn): add setting to disable adding global dir to $PATH #10642

merged 1 commit into from Feb 3, 2022

Conversation

carlosala
Copy link
Member

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.

Changes:

Setting ZSH_YARN_GLOBAL_DISABLE=true prevents adding yarn global bin to the $PATH.
Fixes #10641

@ohmyzsh ohmyzsh bot added Area: plugin Issue or PR related to a plugin Type: documentation Documentation issue or Pull Request labels Feb 1, 2022
@mcornella mcornella changed the title feat(yarn): adding option to disable PATH modifying feat(yarn): add setting to disable adding global dir to $PATH Feb 3, 2022
@mcornella mcornella merged commit d9c58d5 into ohmyzsh:master Feb 3, 2022
@carlosala carlosala deleted the yarn branch February 4, 2022 10:30
lesterchan added a commit to lesterchan/oh-my-zsh that referenced this pull request Feb 5, 2022
@lesterchan
Merge remote-tracking branch 'upstream/master'
ca5e350 
* upstream/master: (41 commits)
  Introducing the ANSI logo graphic
  feat(yarn): add setting to disable adding global dir to `$PATH` (ohmyzsh#10642)
  fix(cli): allow `omz` commands to be used in a script (ohmyzsh#10645)
  feat(multipass): add plugin for multipass (ohmyzsh#10140)
  refactor(zsh_reload)!: remove deprecated plugin
  chore: update copyright year
  refactor(django): remove deprecated `django` plugin
  style(init): use consistent code style in init script (ohmyzsh#10601)
  refactor(installer): use POSIX-standard's `id -u -n` to define `$USER`
  chore(1password): fix comments to follow code (ohmyzsh#10634)
  fix(gitfast): update to git-completion 1.3.6 (ohmyzsh#10633)
  fix(changelog): don't show changelog with only ignored type commits
  style(rkj-repos): change `white` to `default` to support light color schemes (ohmyzsh#6195)
  fix(tmux): use `$ZSH_TMUX_CONFIG` setting in tmuxconf alias
  fix(ys): fix `$VIRTUAL_ENV` check if `nounset` is enabled (ohmyzsh#9915)
  fix(installer): avoid `git clone -c` to support git v1.7.1 (ohmyzsh#10621)
  fix(npx)!: detect new `npx` versions and fail gracefully (ohmyzsh#10452)
  style(updater): silence `git pull` output and show errors in English
  feat(postgres): support Homebrew for Apple Silicon (ohmyzsh#10618)
  fix(cli): make sure to run `zsh` command if an alias exists (ohmyzsh#9737)
  ...
amkirby pushed a commit to amkirby/oh-my-zsh that referenced this pull request Mar 9, 2022
@carlosala @amkirby
feat(yarn): add setting to disable adding global dir to $PATH (ohmy…
cde0e98 
…zsh#10642)
cmoore pushed a commit to cmoore/oh-my-zsh that referenced this pull request Apr 28, 2022
@carlosala @cmoore
feat(yarn): add setting to disable adding global dir to $PATH (ohmy…
7d67c8b 
…zsh#10642)
FelixDombek pushed a commit to FelixDombek/ohmyzsh that referenced this pull request May 18, 2022
@carlosala @FelixDombek-TomTom
feat(yarn): add setting to disable adding global dir to $PATH (ohmy…
0a9c1db 
…zsh#10642)
Daddelhai pushed a commit to Daddelhai/ohmyzsh that referenced this pull request Jul 4, 2022
@carlosala @Daddelhai
feat(yarn): add setting to disable adding global dir to $PATH (ohmy…
968abf2 
…zsh#10642)
kis87988 pushed a commit to kis87988/ohmyzsh that referenced this pull request Jul 5, 2022
@carlosala @kis87988
feat(yarn): add setting to disable adding global dir to $PATH (ohmy…
327bf3b 
…zsh#10642)
tekniklr pushed a commit to tekniklr/oh-my-zsh that referenced this pull request Sep 6, 2022
@carlosala
feat(yarn): add setting to disable adding global dir to $PATH (ohmy…
c9c38b4 
…zsh#10642)
rahdjoudj pushed a commit to rahdjoudj/ohmyzsh that referenced this pull request Nov 3, 2022
@carlosala @reda-sj
feat(yarn): add setting to disable adding global dir to $PATH (ohmy…
c0d589d 
…zsh#10642)
dilfish pushed a commit to dilfish/oh-my-zsh that referenced this pull request Feb 16, 2023
@carlosala
feat(yarn): add setting to disable adding global dir to $PATH (ohmy…
fda615b 
…zsh#10642)
nbaronov pushed a commit to nbaronov/oh-my-zsh that referenced this pull request Aug 3, 2023
@carlosala @nbaronov
feat(yarn): add setting to disable adding global dir to $PATH (ohmy…
bd96497 
…zsh#10642)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: plugin Issue or PR related to a plugin Type: documentation Documentation issue or Pull Request
Projects
Main project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to disable adding yarn global scripts to $PATH
2 participants
@carlosala @mcornella