Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(macos): fix man-preview for macOS Ventura #11324

Merged
merged 1 commit into from
Jan 9, 2023
Merged

fix(macos): fix man-preview for macOS Ventura #11324

merged 1 commit into from
Jan 9, 2023

Conversation

cxy004
Copy link
Contributor

@cxy004 cxy004 commented Nov 8, 2022 •
edited
Loading

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

  • Preview.app on macOS Ventura drops support for PostScript on which the current man-preview function with man -t (basically mandoc -Tps) relies. This commit switches to mandoc -Tpdf and keeps it simple.

@ohmyzsh ohmyzsh bot added the Area: plugin Issue or PR related to a plugin label Nov 8, 2022
@mcornella mcornella self-assigned this Nov 11, 2022
@mcornella
Copy link
Member

Is mandoc installed by default on macOS or would it need to be a separate dependency?

@mcornella mcornella added the Bug Something isn't working label Dec 1, 2022
@rwmitchell
Copy link
Contributor

Default installed on Monterey

@robbyrussell
Copy link
Member

@mcornella by default comes included on Ventura

@robbyrussell robbyrussell merged commit 2c2187b into ohmyzsh:master Jan 9, 2023
@cxy004 cxy004 deleted the macos branch January 11, 2023 08:45
nbaronov pushed a commit to nbaronov/oh-my-zsh that referenced this pull request Aug 3, 2023
@cxy004 @nbaronov
fix(macos): fix man-preview for macOS Ventura (ohmyzsh#11324)
d1c912f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mcornella mcornella

Labels
Area: plugin Issue or PR related to a plugin Bug Something isn't working
Projects
Main project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cxy004 @mcornella @rwmitchell @robbyrussell