Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(englizsh): New plugin to interface any command-line GPT program intuitively through keybindings #11779

Closed
wants to merge 2 commits into from

Conversation

chinarjoshi
Copy link

@chinarjoshi chinarjoshi commented Jun 27, 2023

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

  • Defines 4 keybindings to interface any command-line GPT program. The idea is to toggle the contents of the shell buffer between natural language and shell command and directly execute natural language using GPT as the translator.

  • See https://github.com/chinarjoshi/englizsh/ for usage, demonstrations, and configuration information.

  • Does not create any aliases or completions.

@ohmyzsh ohmyzsh bot added Area: plugin Issue or PR related to a plugin Topic: bindkey Pull Request or issue regarding keyboard shortcuts Type: documentation Documentation issue or Pull Request New: plugin Request for a plugin or Pull Request that adds one labels Jun 27, 2023
@mcornella
Copy link
Member

Hi Chinar, thank you for the submission.

Unfortunately at this point I must reject the PR, here's my reasoning: currently there are many command-based AI tools that are making a case for their usefulness, and at this early stage it is not clear which will be more useful than the other, and therefore more suited for bundlind within OMZ.

We are striving to include tools that are going to make an impact for the vast majority of the users, and at this early stage we don't have a good sense of which ones are more relevant, or deserve our time and effort to maintain.

As more time happens, we might see that, indeed, this plugin is worth the effort and is something that our users demand to be included, and not something that they should install on their own.

For these reasons I'm going to close the PR, but we may revisit this decision in the future.

Thanks for the contribution!

@mcornella mcornella closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: plugin Issue or PR related to a plugin New: plugin Request for a plugin or Pull Request that adds one Topic: bindkey Pull Request or issue regarding keyboard shortcuts Type: documentation Documentation issue or Pull Request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants