Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(poetry-env): activate only if env exists #12301

Merged
merged 1 commit into from Mar 26, 2024
Merged

fix(poetry-env): activate only if env exists #12301

merged 1 commit into from Mar 26, 2024

Conversation

zikoengxi
Copy link
Contributor

@zikoengxi zikoengxi commented Mar 25, 2024 •
edited

activate a non-existent virtual environment.

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

  • Before activating the virtual environment, check whether the virtual environment exists.

@zikoengxi
fix(poetry-env): activate a non-existent virtual environment
1e7a079 
Before activating the virtual environment, check whether the virtual environment exists.
@ohmyzsh ohmyzsh bot added the Area: plugin Issue or PR related to a plugin label Mar 25, 2024
@carlosala carlosala changed the title fix(poetry-env): activate a non-existent virtual environment fix(poetry-env): activate only if env exists Mar 26, 2024
@carlosala carlosala merged commit a168efe into ohmyzsh:master Mar 26, 2024
1 check passed
@carlosala
Copy link
Member

Thanks for your contribution!

fdelacruz pushed a commit to fdelacruz/ohmyzsh that referenced this pull request Mar 27, 2024
@zikoengxi @fdelacruz
fix(poetry-env): activate only if env exists (ohmyzsh#12301)
2ceacb4
pull bot pushed a commit to kis87988/ohmyzsh that referenced this pull request Mar 27, 2024
@zikoengxi @pull
fix(poetry-env): activate only if env exists (ohmyzsh#12301)
e8de458
BougaCaillou added a commit to BougaCaillou/ohmybouga that referenced this pull request Apr 8, 2024
@BougaCaillou
Merge remote-tracking branch 'upstream/master'
3b90955 
* upstream/master:
  Update README for git-prompt to clarify how to use (ohmyzsh#10922)
  fix(autojump): add macOS 'pkgsrc' installation location (ohmyzsh#12329)
  fix(lib/git): fix detection of function use in prompt
  perf(async): avoid executing `true` if not required (ohmyzsh#12318)
  fix(git): disable locally `ksharrays`
  fix(archlinux): make `upgrade` work with non-english
  feat(git): implement async completion for `git_prompt_status` (ohmyzsh#12319)
  feat(git)!: enable async git prompt (now for real)
  fix(async): avoid blocking the shell while waiting (ohmyzsh#12304)
  feat(httpie): complete https command (ohmyzsh#12314)
  feat(gcloud): add homebrew installation path (ohmyzsh#12308)
  fix(starship): keep `ZSH_THEME` if not installed (ohmyzsh#12309)
  style: remove trailing whitespace (ohmyzsh#12303)
  fix(poetry-env): activate only if env exists (ohmyzsh#12301)
  feat(terraform): add `tft` (`terraform test`) (ohmyzsh#12299)
  feat(jira): add help/usage cmd (ohmyzsh#12293)
  fix(ssh-agent): don't start new agent if screen/tmux symlink exists (ohmyzsh#12297)
lukaselmer pushed a commit to lukaselmer/ohmyzsh that referenced this pull request Apr 16, 2024
@zikoengxi @lukaselmer
fix(poetry-env): activate only if env exists (ohmyzsh#12301)
01df855
cschuyle pushed a commit to cschuyle/ohmyzsh that referenced this pull request Apr 18, 2024
@zikoengxi @cschuyle
fix(poetry-env): activate only if env exists (ohmyzsh#12301)
273299a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosala carlosala carlosala approved these changes

Assignees
No one assigned
Labels
Area: plugin Issue or PR related to a plugin
Projects
Main project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zikoengxi @carlosala