Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added https httpie command to completion sources #12314

Merged
merged 1 commit into from Apr 3, 2024
Merged

Added https httpie command to completion sources #12314

merged 1 commit into from Apr 3, 2024

Conversation

ror6ax
Copy link
Contributor

@ror6ax ror6ax commented Apr 2, 2024

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

  • httpie completion now also works on its https command that previously wasn't completed.

@ohmyzsh ohmyzsh bot added Area: plugin Issue or PR related to a plugin Topic: completion Pull Request or issue regarding completion labels Apr 2, 2024
carlosala
carlosala approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@carlosala carlosala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlosala carlosala merged commit 130002a into ohmyzsh:master Apr 3, 2024
1 check passed
@carlosala
Copy link
Member

Thanks!

pull bot pushed a commit to kis87988/ohmyzsh that referenced this pull request Apr 3, 2024
@ror6ax @pull
feat(httpie): complete https command (ohmyzsh#12314)
34690b9
BougaCaillou added a commit to BougaCaillou/ohmybouga that referenced this pull request Apr 8, 2024
@BougaCaillou
Merge remote-tracking branch 'upstream/master'
3b90955 
* upstream/master:
  Update README for git-prompt to clarify how to use (ohmyzsh#10922)
  fix(autojump): add macOS 'pkgsrc' installation location (ohmyzsh#12329)
  fix(lib/git): fix detection of function use in prompt
  perf(async): avoid executing `true` if not required (ohmyzsh#12318)
  fix(git): disable locally `ksharrays`
  fix(archlinux): make `upgrade` work with non-english
  feat(git): implement async completion for `git_prompt_status` (ohmyzsh#12319)
  feat(git)!: enable async git prompt (now for real)
  fix(async): avoid blocking the shell while waiting (ohmyzsh#12304)
  feat(httpie): complete https command (ohmyzsh#12314)
  feat(gcloud): add homebrew installation path (ohmyzsh#12308)
  fix(starship): keep `ZSH_THEME` if not installed (ohmyzsh#12309)
  style: remove trailing whitespace (ohmyzsh#12303)
  fix(poetry-env): activate only if env exists (ohmyzsh#12301)
  feat(terraform): add `tft` (`terraform test`) (ohmyzsh#12299)
  feat(jira): add help/usage cmd (ohmyzsh#12293)
  fix(ssh-agent): don't start new agent if screen/tmux symlink exists (ohmyzsh#12297)
lukaselmer pushed a commit to lukaselmer/ohmyzsh that referenced this pull request Apr 16, 2024
@ror6ax @lukaselmer
feat(httpie): complete https command (ohmyzsh#12314)
a1b064a
cschuyle pushed a commit to cschuyle/ohmyzsh that referenced this pull request Apr 18, 2024
@ror6ax @cschuyle
feat(httpie): complete https command (ohmyzsh#12314)
433d924
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosala carlosala carlosala approved these changes

Assignees
No one assigned
Labels
Area: plugin Issue or PR related to a plugin Topic: completion Pull Request or issue regarding completion
Projects
Main project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ror6ax @carlosala