fix(history)!: fix arg passing to fc for history command
#12338
Conversation
…le when run with the -p flag
mcornella
changed the title
fc for history command
|
The side effect of this change is that the user expects to see the full history when typing |
|
I believe this is not a good solution, as the default behavior of a widely used command has changed. |
|
We could fix that by explicitly handling the case when the user doesn't use any arguments to show all the history starting from 1. This would keep the behaviour the same while still fixing the issue. What do you think? @filipeacacio @mhagnumdw @mcornella @carlosala |
Sounds good for me. |
Great |
|
Merged, thanks folks for the fast turnaround. |
…#12338) BREAKING CHANGE: we have fixed a bug in the `history` wrapper for OMZ which means that running just history will now not show all the history since the 1st command, but only recent ones. To get the previous behavior, you can run `history 1` to get all the command history, or other commands such as `history -30` to get the last 30 commands.
…#12338) BREAKING CHANGE: we have fixed a bug in the `history` wrapper for OMZ which means that running just history will now not show all the history since the 1st command, but only recent ones. To get the previous behavior, you can run `history 1` to get all the command history, or other commands such as `history -30` to get the last 30 commands.
fixes #12334 by not forcing the
1argument and giving the user more control.