Reverting to old behaviour when running just history

[MoAlkhateeb]

Handles:
#12338 (comment)
#12338 (comment)

Running history prints the whole history starting from 1.

[brettmiller]

At least in my case it still only shows the last 16 records. It looks like possibly because of the alias that's set when $HIST_STAMPS is set.

[carlosala]

At least in my case it still only shows the last 16 records. It looks like possibly because of the alias that's set when $HIST_STAMPS is set.

Are you using history directly, or with any parameter?

[brettmiller]

Directly with no parameters.

$ history | wc -l
16
$ which history
history: aliased to omz_history -i

[MoAlkhateeb]

Directly with no parameters.

$ history | wc -l
16
$ which history
history: aliased to omz_history -i

Since history is aliased to omz_history -i and not omz_history, you automatically send a parameter -i. To get the full history, you could run history 1.

I think we should keep the parsing as is because there are many flags (-d, -i, -f, ...) that only change the format of the output of the command. However, another way of handling this would be to explicitly handle the flags that change environment variables (i.e. may have side-effects) differently and make all the other (format) flags print from 1.

Please let me know what your thoughts are.

[brettmiller]

I'm not setting the history alias to omz_history -i that's coming from lib/history.zsh. So, to me it makes since to explicitly handle the aliases it sets as well. Testing locally adding

  elif [[ $# -eq 1 ]]; then
    if [[ $1 -eq "-f" || $1 -eq "-E" || $1 -eq "-i" ]]; then
      builtin fc -l $1 1
    fi

between the if [[ $# -eq 0 ]]; then and elif [[ -n "$clear" ]]; then that was added in this PR seems to handle those cases correctly. I'd be happy to open a PR with that change.

[mcornella]

This is now fixed in #12357 thanks to @artnim. Cheers!