Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pass): completion for multiple repositories #12464

Merged
merged 1 commit into from
May 30, 2024

Conversation

ombre8
Copy link
Contributor

@ombre8 ombre8 commented May 30, 2024

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

Other comments:

without the fix workpass secre[tab] works but workpass edit secre[tab] would search the default pass directory for that secret

@ohmyzsh ohmyzsh bot added Area: plugin Issue or PR related to a plugin Topic: completion Pull Request or issue regarding completion labels May 30, 2024
Copy link
Member

@carlosala carlosala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlosala carlosala changed the title fix(pass): Fix zsh completion for multiple repositories fix(pass): completion for multiple repositories May 30, 2024
@carlosala carlosala merged commit a4424df into ohmyzsh:master May 30, 2024
1 check passed
@carlosala
Copy link
Member

Thanks!

ttelford pushed a commit to ttelford/oh-my-zsh that referenced this pull request Jun 26, 2024
naveen-u pushed a commit to naveen-u/ohmyzsh that referenced this pull request Jul 1, 2024
lytt925 pushed a commit to lytt925/ohmyzsh that referenced this pull request Aug 17, 2024
fdelacruz pushed a commit to fdelacruz/ohmyzsh that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: plugin Issue or PR related to a plugin Topic: completion Pull Request or issue regarding completion
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants