New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes git_compare_version() in lib/git.zsh and refactors the whole file #2386
base: master
Are you sure you want to change the base?
Conversation
Could also fix #2404, if people approve. |
Reenables local hiding of a git prompt for large repositories. Can be toggled through this new function. - Also doesn't falter when a user has no permission to read the git config.
I'm using my own version of oh-my-git now which doesn't rely on oh-my-zsh git functions, so I didn't yet test it, but it seems ok by just reading the code. However I think proper tests need to be done. |
We need some testers! |
@robbyrussell As this resolves my #2928, I'm going to be running this, but I'm not exactly a tester. Merge seems to resolve fine taking all from this ( |
My merge in simonbuchan/oh-my-zsh pull-2386 |
@LFDM This seems to be missing |
Updated my merge, looks like I missed some stuff last try. Looks like Might want to get new |
Minor fix until ohmyzsh/ohmyzsh#2386 or similar is implemented.
git_compare_version() is used to determine whether dirty submodules should be ignored or not, but git has to be more recent than version 1.7.2 to know about that option.
With the former comparison logic a check if git version 1.8.1 is more recent than 1.7.2 turned out negative, which is fixed through this pull request.
UPDATE: In addition to #2401 I refactored the whole file.
Might need some more testing if anything was broken, though I don't have any troubles locally.
Possibly breaking changes: