Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zsh completion plugin for rustc #3159

Merged
merged 1 commit into from
May 27, 2016
Merged

Add zsh completion plugin for rustc #3159

merged 1 commit into from
May 27, 2016

Conversation

scialex
Copy link
Contributor

@scialex scialex commented Sep 19, 2014

This is taken from my PR for rustc (rust-lang/rust#17306), which is getting merged once the CI system is fixed.

@mcornella mcornella mentioned this pull request Sep 29, 2014
Closed
@scialex
Copy link
Contributor Author

scialex commented Oct 23, 2014

Any posibility of getting this merged. The Rust CL has been accepted.

@scialex scialex closed this Oct 23, 2014
@mcornella
Copy link
Member

My proposal was for you to put both rust completion files inside the same plugin, named rust. Then your completion file would keep being the same, and @dahankzter's PR would go into plugins/rust/_cargo.

Though I admit that I don't understand what's the difference between rust and cargo. Care to explain a bit? @dahankzter what do you say?

@dahankzter
Copy link
Contributor

Cargo is basically the canonical dependency resolver and build tool for rust. It basically allows for managing multi module projects and their dependencies in one place.

Having rust and cargo support for zsh in one plugin definitely makes sense.

@mcornella
Copy link
Member

Having rust and cargo support for zsh in one plugin definitely makes sense.

Ok cool. FWIW, I think we can already merge this in, if you care to open it again. We can always modify and merge the other PR later.

I'll cc Robby and let's see if we can fast-track it.

@scialex
Copy link
Contributor Author

scialex commented Oct 28, 2014

mcornella: Sorry. I don't know why it was closed. I didn't mean to.

@scialex scialex reopened this Oct 28, 2014
@jansegre
Copy link

Any news on this?
I'm setting it up manually but would be much more pleased if it were available on oh-my-zsh.

@andradei
Copy link

+1 to have this available.

Right now I'm using antigen and getting a rust plugin from the official rust repo (not updated in a long time)

Maybe a PR over there and antigen would be a nice setup.
Or you guys can make a repo with your plugin and we can use antigen to pull it directly from your repo.

Just a few options.

@orhanbalci
Copy link

Any update on this PR. Since Rust gained some more attention more developers would benefit from this.

@andradei
Copy link

This project should be an organization with more people having the ability to accept PRs like this.

ping @robbyrussell

@mcornella mcornella merged commit 73cca94 into ohmyzsh:master May 27, 2016
@mcornella
Copy link
Member

Sorry for the delay people!

foobacca pushed a commit to foobacca/oh-my-zsh that referenced this pull request May 28, 2016
Merge remote-tracking branch 'upstream/master' into personal
5aab00b 
* upstream/master:
  Add zsh completion plugin for rustc (ohmyzsh#3159)
  Changd `alias gsta='git stash'` to `alias gsta='git stash save'`.
  added assembly alias (ohmyzsh#5107)
  Fix styling in cakephp3 completion
  Better cake3 completion
  Change vim command to $EDITOR for consistency (ohmyzsh#5063)
  fixed bower completion error from issue ohmyzsh#2694 (ohmyzsh#5056)
  vagrant snapshot (ohmyzsh#5032)
  Arcanist plugin (ohmyzsh#5106)
  completion: zsh: improve main function selection
  gitfast: fix the prompt colour
  gitfast: update to upstream v2.8
  Add alias for oneline git tree with --all option
  gitfast: update to upstream v2.4
  gitfast: update to upstream v2.0
  znt: update to v2.1.15
  Add rbenv support for ruby version display
  Added fossil plugin.
  JIRA Plugin will open rapidboard instead of dashboard if JIRA_RAPID_BOARD is true
lesterchan added a commit to lesterchan/oh-my-zsh that referenced this pull request Jun 4, 2016
@lesterchan
Merge remote-tracking branch 'upstream/master'
ea45d26 
* upstream/master: (40 commits)
  Fix arcanist aliases (ohmyzsh#5110)
  add plugin react-native (ohmyzsh#4606)
  installer: fix ordering of cygwin msys git check (ohmyzsh#4557)
  Use default branch on recently created Mercurial repository. (ohmyzsh#4985)
  Add zsh completion plugin for rustc (ohmyzsh#3159)
  Changd `alias gsta='git stash'` to `alias gsta='git stash save'`.
  added assembly alias (ohmyzsh#5107)
  Fix styling in cakephp3 completion
  Better cake3 completion
  Change vim command to $EDITOR for consistency (ohmyzsh#5063)
  fixed bower completion error from issue ohmyzsh#2694 (ohmyzsh#5056)
  vagrant snapshot (ohmyzsh#5032)
  Arcanist plugin (ohmyzsh#5106)
  completion: zsh: improve main function selection
  gitfast: fix the prompt colour
  gitfast: update to upstream v2.8
  Add alias for oneline git tree with --all option
  gitfast: update to upstream v2.4
  gitfast: update to upstream v2.0
  znt: update to v2.1.15
  ...
rakeshbala pushed a commit to rakeshbala/oh-my-zsh that referenced this pull request Jun 6, 2016
@scialex @rakeshbala
Add zsh completion plugin for rustc (ohmyzsh#3159)
930cd34
freecastle added a commit to freecastle/oh-my-zsh that referenced this pull request Jun 7, 2016
@freecastle
Merge branch 'master' of https://github.com/robbyrussell/oh-my-zsh
f7c97a2 
* 'master' of https://github.com/robbyrussell/oh-my-zsh:
  Add list-timers to systemd user commands (ohmyzsh#5099)
  Adds ReactNative plugin 📱 (ohmyzsh#5018)
  Fix arcanist aliases (ohmyzsh#5110)
  add plugin react-native (ohmyzsh#4606)
  installer: fix ordering of cygwin msys git check (ohmyzsh#4557)
  Use default branch on recently created Mercurial repository. (ohmyzsh#4985)
  Add zsh completion plugin for rustc (ohmyzsh#3159)
  Changd `alias gsta='git stash'` to `alias gsta='git stash save'`.
  Support bundler
neiljdo added a commit to neiljdo/oh-my-zsh that referenced this pull request Jun 8, 2016
@neiljdo
Merge branch 'master' of https://github.com/robbyrussell/oh-my-zsh
62f8d4d 
* 'master' of https://github.com/robbyrussell/oh-my-zsh: (69 commits)
  Fix: Plugin knife: Add relative local path for commands which upload files (ohmyzsh#4240)
  Add list-timers to systemd user commands (ohmyzsh#5099)
  Adds ReactNative plugin 📱 (ohmyzsh#5018)
  Fix arcanist aliases (ohmyzsh#5110)
  add plugin react-native (ohmyzsh#4606)
  installer: fix ordering of cygwin msys git check (ohmyzsh#4557)
  Use default branch on recently created Mercurial repository. (ohmyzsh#4985)
  Add zsh completion plugin for rustc (ohmyzsh#3159)
  Changd `alias gsta='git stash'` to `alias gsta='git stash save'`.
  added assembly alias (ohmyzsh#5107)
  Fix styling in cakephp3 completion
  Better cake3 completion
  Change vim command to $EDITOR for consistency (ohmyzsh#5063)
  fixed bower completion error from issue ohmyzsh#2694 (ohmyzsh#5056)
  vagrant snapshot (ohmyzsh#5032)
  Arcanist plugin (ohmyzsh#5106)
  completion: zsh: improve main function selection
  gitfast: fix the prompt colour
  gitfast: update to upstream v2.8
  Add alias for oneline git tree with --all option
  ...
sprig added a commit to sprig/oh-my-zsh that referenced this pull request Jun 20, 2016
@sprig
Merge branch 'master' of https://github.com/robbyrussell/oh-my-zsh in…
0f91058 
…to robbyrussell-master

* 'master' of https://github.com/robbyrussell/oh-my-zsh: (454 commits)
  znt: update to v2.2.1 (ohmyzsh#5174)
  emacs plugin tweak to open buffer from stdin (ohmyzsh#5126)
  Update taskwarrior completion to 2.5.1 (ohmyzsh#5171)
  Remove undesirable hardcoding of PATH into zshrc (ohmyzsh#4925)
  Add README for OSX plugin and refactor plugin file
  Open finder to PWD - part 2 (ohmyzsh#5165)
  Add ofd() to OSX plugin to open finder on current directory (ohmyzsh#5164)
  add 'mvn clean install -DskipTests --offline' alias to speed up maven compile (ohmyzsh#5153)
  Peepcode theme: Don't try to use RVM if it's not available (ohmyzsh#5154)
  Replace _kitchen completion with the version from zsh-users (ohmyzsh#5011)
  Mod: use new debug namespace to avoid deprecation warning (ohmyzsh#4799)
  Fix: Plugin knife: Add relative local path for commands which upload files (ohmyzsh#4240)
  Add list-timers to systemd user commands (ohmyzsh#5099)
  Adds ReactNative plugin 📱 (ohmyzsh#5018)
  Fix arcanist aliases (ohmyzsh#5110)
  add plugin react-native (ohmyzsh#4606)
  installer: fix ordering of cygwin msys git check (ohmyzsh#4557)
  Use default branch on recently created Mercurial repository. (ohmyzsh#4985)
  Add zsh completion plugin for rustc (ohmyzsh#3159)
  Changd `alias gsta='git stash'` to `alias gsta='git stash save'`.
  ...
zhangweifang pushed a commit to zhangweifang/oh-my-zsh that referenced this pull request Jun 21, 2016
@scialex @zwf
Add zsh completion plugin for rustc (ohmyzsh#3159)
b0df0cd
sprig added a commit to sprig/oh-my-zsh that referenced this pull request Jun 25, 2016
@sprig
Merge branch 'master' of github.com:sprig/oh-my-zsh
aa85639 
* 'master' of github.com:sprig/oh-my-zsh: (455 commits)
  quoted a string
  znt: update to v2.2.1 (ohmyzsh#5174)
  emacs plugin tweak to open buffer from stdin (ohmyzsh#5126)
  Update taskwarrior completion to 2.5.1 (ohmyzsh#5171)
  Remove undesirable hardcoding of PATH into zshrc (ohmyzsh#4925)
  Add README for OSX plugin and refactor plugin file
  Open finder to PWD - part 2 (ohmyzsh#5165)
  Add ofd() to OSX plugin to open finder on current directory (ohmyzsh#5164)
  add 'mvn clean install -DskipTests --offline' alias to speed up maven compile (ohmyzsh#5153)
  Peepcode theme: Don't try to use RVM if it's not available (ohmyzsh#5154)
  Replace _kitchen completion with the version from zsh-users (ohmyzsh#5011)
  Mod: use new debug namespace to avoid deprecation warning (ohmyzsh#4799)
  Fix: Plugin knife: Add relative local path for commands which upload files (ohmyzsh#4240)
  Add list-timers to systemd user commands (ohmyzsh#5099)
  Adds ReactNative plugin 📱 (ohmyzsh#5018)
  Fix arcanist aliases (ohmyzsh#5110)
  add plugin react-native (ohmyzsh#4606)
  installer: fix ordering of cygwin msys git check (ohmyzsh#4557)
  Use default branch on recently created Mercurial repository. (ohmyzsh#4985)
  Add zsh completion plugin for rustc (ohmyzsh#3159)
  ...
atsuya pushed a commit to atsuya/oh-my-zsh that referenced this pull request Jul 23, 2016
@scialex @atsuya
Add zsh completion plugin for rustc (ohmyzsh#3159)
0a3058e
bwkeller pushed a commit to bwkeller/oh-my-zsh that referenced this pull request Aug 6, 2016
@scialex @bwkeller
Add zsh completion plugin for rustc (ohmyzsh#3159)
e309289
DennisDenuto pushed a commit to DennisDenuto/oh-my-zsh that referenced this pull request Oct 29, 2016
@scialex @DennisDenuto
Add zsh completion plugin for rustc (ohmyzsh#3159)
624f8a8
avleen pushed a commit to avleen/oh-my-zsh that referenced this pull request Dec 23, 2016
@scialex @avleen
Add zsh completion plugin for rustc (ohmyzsh#3159)
7000713
seth-cohen pushed a commit to seth-cohen/oh-my-zsh that referenced this pull request Oct 29, 2018
@scialex
Add zsh completion plugin for rustc (ohmyzsh#3159)
0bf0a64
jmartindf pushed a commit to jmartindf/oh-my-zsh that referenced this pull request Nov 10, 2018
@scialex @jmartindf
Add zsh completion plugin for rustc (ohmyzsh#3159)
0f86fef
spiliopoulos pushed a commit to spiliopoulos/zsh-config that referenced this pull request Jun 17, 2020
@scialex @spiliopoulos
Add zsh completion plugin for rustc (ohmyzsh#3159)
c1317ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@scialex @mcornella @dahankzter @jansegre @andradei @orhanbalci