Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installer: fix ordering of Cygwin MSYS git check #4557

Merged
merged 1 commit into from
May 30, 2016
Merged

installer: fix ordering of Cygwin MSYS git check #4557

merged 1 commit into from
May 30, 2016

Conversation

apjanke
Copy link
Contributor

@apjanke apjanke commented Oct 29, 2015

The test added in #3646 to prevent use of the incompatible MSYS git isn't working because the test ended up after the git clone call. This moves it to the right location.

Fixes #4551.

@apjanke apjanke mentioned this pull request Oct 29, 2015
Closed
@apjanke apjanke changed the title installer: fix ordering of cygwin msys git check installer: fix ordering of Cygwin MSYS git check Oct 29, 2015
@mcornella mcornella added the Area: installer Issue or PR related to the installer label Dec 15, 2015
@mcornella mcornella merged commit 483f120 into ohmyzsh:master May 30, 2016
lesterchan added a commit to lesterchan/oh-my-zsh that referenced this pull request Jun 4, 2016
@lesterchan
Merge remote-tracking branch 'upstream/master'
ea45d26 
* upstream/master: (40 commits)
  Fix arcanist aliases (ohmyzsh#5110)
  add plugin react-native (ohmyzsh#4606)
  installer: fix ordering of cygwin msys git check (ohmyzsh#4557)
  Use default branch on recently created Mercurial repository. (ohmyzsh#4985)
  Add zsh completion plugin for rustc (ohmyzsh#3159)
  Changd `alias gsta='git stash'` to `alias gsta='git stash save'`.
  added assembly alias (ohmyzsh#5107)
  Fix styling in cakephp3 completion
  Better cake3 completion
  Change vim command to $EDITOR for consistency (ohmyzsh#5063)
  fixed bower completion error from issue ohmyzsh#2694 (ohmyzsh#5056)
  vagrant snapshot (ohmyzsh#5032)
  Arcanist plugin (ohmyzsh#5106)
  completion: zsh: improve main function selection
  gitfast: fix the prompt colour
  gitfast: update to upstream v2.8
  Add alias for oneline git tree with --all option
  gitfast: update to upstream v2.4
  gitfast: update to upstream v2.0
  znt: update to v2.1.15
  ...
rakeshbala pushed a commit to rakeshbala/oh-my-zsh that referenced this pull request Jun 6, 2016
@apjanke @rakeshbala
installer: fix ordering of cygwin msys git check (ohmyzsh#4557)
b57766e
freecastle added a commit to freecastle/oh-my-zsh that referenced this pull request Jun 7, 2016
@freecastle
Merge branch 'master' of https://github.com/robbyrussell/oh-my-zsh
f7c97a2 
* 'master' of https://github.com/robbyrussell/oh-my-zsh:
  Add list-timers to systemd user commands (ohmyzsh#5099)
  Adds ReactNative plugin 📱 (ohmyzsh#5018)
  Fix arcanist aliases (ohmyzsh#5110)
  add plugin react-native (ohmyzsh#4606)
  installer: fix ordering of cygwin msys git check (ohmyzsh#4557)
  Use default branch on recently created Mercurial repository. (ohmyzsh#4985)
  Add zsh completion plugin for rustc (ohmyzsh#3159)
  Changd `alias gsta='git stash'` to `alias gsta='git stash save'`.
  Support bundler
neiljdo added a commit to neiljdo/oh-my-zsh that referenced this pull request Jun 8, 2016
@neiljdo
Merge branch 'master' of https://github.com/robbyrussell/oh-my-zsh
62f8d4d 
* 'master' of https://github.com/robbyrussell/oh-my-zsh: (69 commits)
  Fix: Plugin knife: Add relative local path for commands which upload files (ohmyzsh#4240)
  Add list-timers to systemd user commands (ohmyzsh#5099)
  Adds ReactNative plugin 📱 (ohmyzsh#5018)
  Fix arcanist aliases (ohmyzsh#5110)
  add plugin react-native (ohmyzsh#4606)
  installer: fix ordering of cygwin msys git check (ohmyzsh#4557)
  Use default branch on recently created Mercurial repository. (ohmyzsh#4985)
  Add zsh completion plugin for rustc (ohmyzsh#3159)
  Changd `alias gsta='git stash'` to `alias gsta='git stash save'`.
  added assembly alias (ohmyzsh#5107)
  Fix styling in cakephp3 completion
  Better cake3 completion
  Change vim command to $EDITOR for consistency (ohmyzsh#5063)
  fixed bower completion error from issue ohmyzsh#2694 (ohmyzsh#5056)
  vagrant snapshot (ohmyzsh#5032)
  Arcanist plugin (ohmyzsh#5106)
  completion: zsh: improve main function selection
  gitfast: fix the prompt colour
  gitfast: update to upstream v2.8
  Add alias for oneline git tree with --all option
  ...
foobacca pushed a commit to foobacca/oh-my-zsh that referenced this pull request Jun 12, 2016
Merge remote-tracking branch 'upstream/master' into personal
5c67950 
* upstream/master:
  Mod: use new debug namespace to avoid deprecation warning (ohmyzsh#4799)
  Fix: Plugin knife: Add relative local path for commands which upload files (ohmyzsh#4240)
  Add list-timers to systemd user commands (ohmyzsh#5099)
  Adds ReactNative plugin 📱 (ohmyzsh#5018)
  Fix arcanist aliases (ohmyzsh#5110)
  add plugin react-native (ohmyzsh#4606)
  installer: fix ordering of cygwin msys git check (ohmyzsh#4557)
  Use default branch on recently created Mercurial repository. (ohmyzsh#4985)
  Support bundler
sprig added a commit to sprig/oh-my-zsh that referenced this pull request Jun 20, 2016
@sprig
Merge branch 'master' of https://github.com/robbyrussell/oh-my-zsh in…
0f91058 
…to robbyrussell-master

* 'master' of https://github.com/robbyrussell/oh-my-zsh: (454 commits)
  znt: update to v2.2.1 (ohmyzsh#5174)
  emacs plugin tweak to open buffer from stdin (ohmyzsh#5126)
  Update taskwarrior completion to 2.5.1 (ohmyzsh#5171)
  Remove undesirable hardcoding of PATH into zshrc (ohmyzsh#4925)
  Add README for OSX plugin and refactor plugin file
  Open finder to PWD - part 2 (ohmyzsh#5165)
  Add ofd() to OSX plugin to open finder on current directory (ohmyzsh#5164)
  add 'mvn clean install -DskipTests --offline' alias to speed up maven compile (ohmyzsh#5153)
  Peepcode theme: Don't try to use RVM if it's not available (ohmyzsh#5154)
  Replace _kitchen completion with the version from zsh-users (ohmyzsh#5011)
  Mod: use new debug namespace to avoid deprecation warning (ohmyzsh#4799)
  Fix: Plugin knife: Add relative local path for commands which upload files (ohmyzsh#4240)
  Add list-timers to systemd user commands (ohmyzsh#5099)
  Adds ReactNative plugin 📱 (ohmyzsh#5018)
  Fix arcanist aliases (ohmyzsh#5110)
  add plugin react-native (ohmyzsh#4606)
  installer: fix ordering of cygwin msys git check (ohmyzsh#4557)
  Use default branch on recently created Mercurial repository. (ohmyzsh#4985)
  Add zsh completion plugin for rustc (ohmyzsh#3159)
  Changd `alias gsta='git stash'` to `alias gsta='git stash save'`.
  ...
zhangweifang pushed a commit to zhangweifang/oh-my-zsh that referenced this pull request Jun 21, 2016
@apjanke @zwf
installer: fix ordering of cygwin msys git check (ohmyzsh#4557)
e2d9201
sprig added a commit to sprig/oh-my-zsh that referenced this pull request Jun 25, 2016
@sprig
Merge branch 'master' of github.com:sprig/oh-my-zsh
aa85639 
* 'master' of github.com:sprig/oh-my-zsh: (455 commits)
  quoted a string
  znt: update to v2.2.1 (ohmyzsh#5174)
  emacs plugin tweak to open buffer from stdin (ohmyzsh#5126)
  Update taskwarrior completion to 2.5.1 (ohmyzsh#5171)
  Remove undesirable hardcoding of PATH into zshrc (ohmyzsh#4925)
  Add README for OSX plugin and refactor plugin file
  Open finder to PWD - part 2 (ohmyzsh#5165)
  Add ofd() to OSX plugin to open finder on current directory (ohmyzsh#5164)
  add 'mvn clean install -DskipTests --offline' alias to speed up maven compile (ohmyzsh#5153)
  Peepcode theme: Don't try to use RVM if it's not available (ohmyzsh#5154)
  Replace _kitchen completion with the version from zsh-users (ohmyzsh#5011)
  Mod: use new debug namespace to avoid deprecation warning (ohmyzsh#4799)
  Fix: Plugin knife: Add relative local path for commands which upload files (ohmyzsh#4240)
  Add list-timers to systemd user commands (ohmyzsh#5099)
  Adds ReactNative plugin 📱 (ohmyzsh#5018)
  Fix arcanist aliases (ohmyzsh#5110)
  add plugin react-native (ohmyzsh#4606)
  installer: fix ordering of cygwin msys git check (ohmyzsh#4557)
  Use default branch on recently created Mercurial repository. (ohmyzsh#4985)
  Add zsh completion plugin for rustc (ohmyzsh#3159)
  ...
atsuya pushed a commit to atsuya/oh-my-zsh that referenced this pull request Jul 23, 2016
@apjanke @atsuya
installer: fix ordering of cygwin msys git check (ohmyzsh#4557)
cb6cde4
bwkeller pushed a commit to bwkeller/oh-my-zsh that referenced this pull request Aug 6, 2016
@apjanke @bwkeller
installer: fix ordering of cygwin msys git check (ohmyzsh#4557)
b831565
DennisDenuto pushed a commit to DennisDenuto/oh-my-zsh that referenced this pull request Oct 29, 2016
@apjanke @DennisDenuto
installer: fix ordering of cygwin msys git check (ohmyzsh#4557)
2ec6850
avleen pushed a commit to avleen/oh-my-zsh that referenced this pull request Dec 23, 2016
@apjanke @avleen
installer: fix ordering of cygwin msys git check (ohmyzsh#4557)
6ebb8f5
seth-cohen pushed a commit to seth-cohen/oh-my-zsh that referenced this pull request Oct 29, 2018
@apjanke
installer: fix ordering of cygwin msys git check (ohmyzsh#4557)
7f499ba
jmartindf pushed a commit to jmartindf/oh-my-zsh that referenced this pull request Nov 10, 2018
@apjanke @jmartindf
installer: fix ordering of cygwin msys git check (ohmyzsh#4557)
369ba1d
spiliopoulos pushed a commit to spiliopoulos/zsh-config that referenced this pull request Jun 17, 2020
@apjanke @spiliopoulos
installer: fix ordering of cygwin msys git check (ohmyzsh#4557)
568bbb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: installer Issue or PR related to the installer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@apjanke @mcornella