-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move server and scheduler start code. #71
Merged
adamstruck
merged 10 commits into
ohsu-comp-bio:master
from
buchanae:http-server-refactor
Apr 14, 2017
Merged
Move server and scheduler start code. #71
adamstruck
merged 10 commits into
ohsu-comp-bio:master
from
buchanae:http-server-refactor
Apr 14, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
buchanae
commented
Apr 13, 2017
- Shuffles some server and scheduler code around to clean things up.
- Tries to simplify the cmd/server.go code needed to start a funnel server. Partially succeeds.
- Renames Scheduler to Backend, then creates Scheduler to represent high-level Scheduler server/controller
- Server/Scheduler create code is more easily reused by tests which create a mock server.
- Better use of context by scheduler
- Adds "Cache-Control: no-store" HTTP response header to prevent responses from being cached. This is configurable with config.DisableHTTPCaching (default true)
- Adds "make go-test" command for running the go tests only. The need for this command is another reason I'd like to move the code out of src/funnel.
This also takes one small step towards being able to create a pluggable database backend by relying on a separate Database interface for both Scheduler and Server, and requiring that database be passed in to NewServer and NewScheduler. |
This also prunes the gorilla dependency, since all path mapping is now handled by core Go http library. |
16bdce3
to
cb7231f
Compare
* Drop global registry in favor of much simpler Scheduler.AddBackend * Clean up duplicate mock server code * Simplify Scheduler.Start
8267c83
to
daa353d
Compare
The latest commits:
|
b5c5719
to
49a3b56
Compare
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.