-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
laminar closing connection on (larger?) files #37
Comments
I am not really surprised by this, Laminar doesn’t include the necessary smarts for serving up larger files, it doesn’t matter if you put it behind a proxy or not. Perhaps it’s not clear enough in the documentation, but my current recommendation is to let the http front proxy handle it completely, that is, define a “location” match on the archive url in nginx or apache and have it serve laminar’s archive directory, without any involvement from laminar itself. I admit it’s not so convenient, and I am probably asking for trouble by allowing basic file serving in the first place, but I didn’t want to reinvent the wheel here. All that said, now that capnp has http built in it might not be so difficult to do it properly. I’ll probably take another look when I do the next refactor... |
OK, no problem to proxy the archive, I just must have missed it in
documentation. Thank you for clarifying.
…On Thu, Apr 12, 2018 at 6:22 PM Oliver Giles ***@***.***> wrote:
I am not really surprised by this, Laminar doesn’t include the necessary
smarts for serving up larger files, it doesn’t matter if you put it behind
a proxy or not.
Perhaps it’s not clear enough in the documentation, but my current
recommendation is to let the http front proxy handle it completely, that
is, define a “location” match on the archive url in nginx or apache and
have it serve laminar’s archive directory, without any involvement from
laminar itself.
I admit it’s not so convenient, and I am probably asking for trouble by
allowing basic file serving in the first place, but I didn’t want to
reinvent the wheel here.
All that said, now that capnp has http built in it might not be so
difficult to do it properly. I’ll probably take another look when I do the
next refactor...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADB9OrPZEbH4SOhjhgIBeh7qTmYpeASMks5tn382gaJpZM4TR68e>
.
|
The old implementation slurped the whole artefact into memory, and did not ensure it remained allocated beyond the first call to write(). The new implementation uses mmap and ensures the mapping lasts until the file has been delivered
When I am trying to download a file from laminar's archive I am getting this:
This is even directly downloading
I am running without proxy, so :8080 is directly laminar listening for requests.
But running with proxy doesn't make it better.
2018-04-12 16:39:16 (602 KB/s) - Connection closed at byte 3404021. Retrying.
How can I help to debug it for you some more?
The text was updated successfully, but these errors were encountered: