-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added define config with OIDC_LOGIN_TYPE and OIDC_CLIENT_SCOPE #256
Conversation
scopes are needed when logging in so this is a no-brainer and this can be deployed using deployments login type can be defined here when you want to enforce SSO from the deployment.
Hi there, the tests have failed but I have no idea why. It's a straight branch from develop and the changes are really minor. |
/travis_retry |
opening a new issue. |
@ChloeTigre your PR is passing now. Will take a deeper look and consider it for inclusion in the next 3.9 feature release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChloeTigre comments made some changes are required. Thanks!
Yes doing that! |
There :) thanks. |
Hey there ! I have no time to care for the README.md change and I am unsure of the desired styling. Can someone take care of this? I'd like to get this merged but it's out of my professional scope at the moment. |
All Submissions:
Changes proposed in this Pull Request:
I add here support for define() settings for two variables:
login_type
andscope
.OIDC_CLIENT_SCOPE
is a space-separated list of scopes.OIDC_LOGIN_TYPE
can either bebutton
orauto
. Other values have undefined behaviour.OIDC_ENFORCE_PRIVACY
(boolean): enable/disable the eponymous optionOIDC_CREATE_IF_DOES_NOT_EXIST
(boolean) enable/disable the eponymous optionOIDC_LINK_EXISTING_USERS
(boolean) enable/disable the eponymous optionOIDC_REDIRECT_USER_BACK
(boolean) enable/disable the eponymous optionOIDC_REDIRECT_ON_LOGOUT
(boolean) enable/disable the eponymous optionHow to test the changes in this Pull Request:
define('OIDC_CLIENT_SCOPE', 'email openid profile')
in your wp-config.phpOIDC_LOGIN_TYPE
and the other variables.Other information:
Changelog entry
Added seven new environment variables matching the options in the settings page.
Setting these
define
s disables changing the options in the interface.OIDC_CLIENT_SCOPE
: a space-separated list of scopes.OIDC_LOGIN_TYPE
: (button
|auto
)OIDC_ENFORCE_PRIVACY
(boolean): enable/disable the eponymous optionOIDC_CREATE_IF_DOES_NOT_EXIST
(boolean) enable/disable the eponymous optionOIDC_LINK_EXISTING_USERS
(boolean) enable/disable the eponymous optionOIDC_REDIRECT_USER_BACK
(boolean) enable/disable the eponymous optionOIDC_REDIRECT_ON_LOGOUT
(boolean) enable/disable the eponymous option