added define config with OIDC_LOGIN_TYPE and OIDC_CLIENT_SCOPE #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scopes are needed when logging in so this is a no-brainer and this can be deployed using deployments login type can be defined here when you want to enforce SSO from the deployment.
|
Hi there, the tests have failed but I have no idea why. It's a straight branch from develop and the changes are really minor. |
|
/travis_retry |
|
opening a new issue. |
timnolte
added
enhancement
|
@ChloeTigre your PR is passing now. Will take a deeper look and consider it for inclusion in the next 3.9 feature release. |
timnolte
requested changes
Jan 13, 2021
|
Yes doing that! |
|
There :) thanks. |
|
Hey there ! I have no time to care for the README.md change and I am unsure of the desired styling. Can someone take care of this? I'd like to get this merged but it's out of my professional scope at the moment. |
timnolte
approved these changes
Dec 29, 2021
timnolte
added
status: approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
I add here support for define() settings for two variables:
login_typeandscope.OIDC_CLIENT_SCOPEis a space-separated list of scopes.OIDC_LOGIN_TYPEcan either bebuttonorauto. Other values have undefined behaviour.OIDC_ENFORCE_PRIVACY(boolean): enable/disable the eponymous optionOIDC_CREATE_IF_DOES_NOT_EXIST(boolean) enable/disable the eponymous optionOIDC_LINK_EXISTING_USERS(boolean) enable/disable the eponymous optionOIDC_REDIRECT_USER_BACK(boolean) enable/disable the eponymous optionOIDC_REDIRECT_ON_LOGOUT(boolean) enable/disable the eponymous optionHow to test the changes in this Pull Request:
define('OIDC_CLIENT_SCOPE', 'email openid profile')in your wp-config.phpOIDC_LOGIN_TYPEand the other variables.Other information:
Changelog entry
Added seven new environment variables matching the options in the settings page.
Setting these
defines disables changing the options in the interface.OIDC_CLIENT_SCOPE: a space-separated list of scopes.OIDC_LOGIN_TYPE: (button|auto)OIDC_ENFORCE_PRIVACY(boolean): enable/disable the eponymous optionOIDC_CREATE_IF_DOES_NOT_EXIST(boolean) enable/disable the eponymous optionOIDC_LINK_EXISTING_USERS(boolean) enable/disable the eponymous optionOIDC_REDIRECT_USER_BACK(boolean) enable/disable the eponymous optionOIDC_REDIRECT_ON_LOGOUT(boolean) enable/disable the eponymous option