Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes QS not being added to the redirect URL #335

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Conversation

slykar
Copy link
Contributor

@slykar slykar commented Sep 7, 2021

All Submissions:

Changes proposed in this Pull Request:

On my WP installation the QS is lost when saving the redirect URL. Those changes fix the issue.

How to test the changes in this Pull Request:

  1. go to any login-protected URL with any query string
  2. login
  3. you should get back to page with query string present

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Fixes QS not being added to the redirect URL

timnolte
timnolte previously approved these changes Dec 29, 2021
@timnolte timnolte self-assigned this Dec 29, 2021
@timnolte timnolte added the bug label Dec 29, 2021
@timnolte timnolte added this to the 3.8.6 milestone Dec 29, 2021
@timnolte timnolte added the status: approved PRs that have been approved and ready to be merged. label Dec 29, 2021
@timnolte timnolte modified the milestones: 3.8.6, 3.9.0 Feb 25, 2022
@timnolte timnolte added this to To do in 3.9.0 Release via automation Mar 17, 2022
3.9.0 Release automation moved this from To do to In progress Mar 17, 2022
@timnolte timnolte merged commit 2ddc368 into oidc-wp:dev Mar 17, 2022
3.9.0 Release automation moved this from In progress to Done Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug status: approved PRs that have been approved and ready to be merged.
Projects
No open projects
3.8.6 Release
Awaiting triage
3.9.0 Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants