Skip to content

Commit

Permalink
[cleanup] A couple TODOs in bin/oil.py.
Browse files Browse the repository at this point in the history
  • Loading branch information
Andy Chu committed Oct 10, 2018
1 parent 4d10a3d commit 066696d
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions bin/oil.py
Expand Up @@ -248,6 +248,7 @@ def OshMain(argv0, argv, login_shell):
# register path completion
comp_builtins.Complete(['-D', '-A', 'file'], ex, comp_lookup)

# TODO: Move this into demo/slow-completion.sh
if 1:
# Something for fun, to show off. Also: test that you don't repeatedly hit
# the file system / network / coprocess.
Expand All @@ -258,11 +259,8 @@ def OshMain(argv0, argv, login_shell):

return main_loop.Interactive(opts, ex, c_parser, arena)

# Parse the whole thing up front
#print('Parsing file')

# Do this after parsing the entire file. There could be another option to
# do it before exiting runtime?
# TODO: Remove this after removing it from benchmarks/osh-runtime. It's no
# longer relevant with main_loop.
if opts.parser_mem_dump:
# This might be superstition, but we want to let the value stabilize
# after parsing. bash -c 'cat /proc/$$/status' gives different results
Expand All @@ -278,7 +276,6 @@ def OshMain(argv0, argv, login_shell):
nodes_out = [] if exec_opts.noexec else None

_tlog('Execute(node)')
#status = ex.ExecuteAndRunExitTrap(node)
status = main_loop.Batch(ex, c_parser, arena, nodes_out=nodes_out)

if nodes_out is not None:
Expand Down

0 comments on commit 066696d

Please sign in to comment.