[test/spec] Audit arith, array-compat, array.

Addresses issue #311.

- arith: Mark failures as OK.  We don't implement insecure runtime
  parsing.

metrics/tarball.sh

@@ -75,6 +75,10 @@ linecount-pydeps-src-only() {
   echo
   _wc-header
   _py-deps-src-only | sort | uniq | xargs wc -l | sort -n
+
+  echo
+  echo 'ASDL SCHEMAS'
+  wc -l "${ASDL_FILES[@]}"
 }
 
 # hello: 1.41 MB native + 145 KB = 1.56 MB bundle

spec/arith.test.sh

@@ -264,6 +264,7 @@ foo=5
 x=oo
 echo $(( foo + f$x + 1 ))
 ## stdout: 11
+## OK osh stdout: 6
 
 #### Bizarre recursive name evaluation - result of runtime parse/eval
 foo=5
@@ -272,6 +273,7 @@ spam=bar
 eggs=spam
 echo $((foo+1)) $((bar+1)) $((spam+1)) $((eggs+1))
 ## stdout: 6 6 6 6
+## OK osh stdout: 6 1 1 1
 ## N-I dash stdout-json: ""
 ## N-I dash status: 2
 

spec/array-compat.test.sh

@@ -27,15 +27,15 @@ b="${a[@]}"  # this collapses to a string
 c=("${a[@]}")  # this preserves the array
 c[1]=YYY  # mutate a copy -- doesn't affect the original
 argv.py "${a[@]}"
-argv.py "${b[@]}"
+argv.py "${b}"
 argv.py "${c[@]}"
 ## STDOUT:
 ['x', 'y', 'z']
 ['x y z']
 ['x', 'YYY', 'z']
 ## END
 
-#### $a gives first element of array
+#### $a gives first element of array (TODO: osh should disallow)
 a=(1 '2 3')
 echo $a
 ## stdout: 1
@@ -64,11 +64,13 @@ echo ${#a[@]} ${#s}
 EQUAL
 ## END
 
-#### Increment array variables
-a=(1 2)
+#### ++ on a whole array increments the first element (disallowed in OSH)
+a=(1 10)
 (( a++ ))  # doesn't make sense
 echo "${a[@]}"
-## stdout: 2 2
+## stdout: 2 10
+## OK osh status: 1
+## OK osh stdout-json: ""
 
 #### Apply vectorized operations on ${a[*]}
 a=('-x-' 'y-y' '-z-')

spec/array.test.sh

@@ -147,7 +147,7 @@ argv.py "${!a[1]}"
 ## stdout: ['bar']
 ## N-I mksh stdout: ['a[1]']
 
-#### ${!a} on array
+#### ${!a} on array (TODO: OSH should disallow)
 # bash gives empty string?
 # mksh gives the name of the variable with !.  Very weird.
 a=(1 '2 3')

test/runtime-errors.sh

@@ -437,6 +437,12 @@ multiple_assign_2() {
   echo $y
 }
 
+string_as_array() {
+  local str='foo'
+  echo $str
+  echo "${str[@]}"
+}
+
 #
 # BUILTINS
 #
@@ -623,7 +629,7 @@ all() {
     nounset_arith divzero divzero_var array_arith undef_arith undef_arith2 \
     undef_assoc_array \
     string_to_int_arith string_to_hex string_to_octal \
-    string_to_intbase string_to_int_bool \
+    string_to_intbase string_to_int_bool string_as_array \
     array_assign_1 array_assign_2 readonly_assign \
     multiple_assign multiple_assign_2 patsub_bad_glob \
     builtin_bracket builtin_builtin builtin_source builtin_cd builtin_pushd \

test/spec.sh

@@ -394,7 +394,7 @@ glob() {
 }
 
 arith() {
-  sh-spec spec/arith.test.sh --osh-failures-allowed 2 \
+  sh-spec spec/arith.test.sh \
     ${REF_SHELLS[@]} $ZSH $OSH_LIST "$@"
 }
 
@@ -542,7 +542,7 @@ array() {
 }
 
 array-compat() {
-  sh-spec spec/array-compat.test.sh --osh-failures-allowed 4 \
+  sh-spec spec/array-compat.test.sh --osh-failures-allowed 2 \
     $BASH $MKSH $OSH_LIST "$@"
 }