Respect -a and -A flags to declare/typeset.

This gets us a bit further in the bash_completion script.

core/cmd_exec.py

@@ -771,7 +771,13 @@ def _Dispatch(self, node, fork_external):
             assert isinstance(val, runtime.value), val
           else:
             # e.g. 'readonly x' or 'local x'
-            val = None  # only changing flags
+            if var_flags_e.Array in flags:
+              val = runtime.StrArray([])
+            elif var_flags_e.AssocArray in flags:
+              # TODO: AssocArray
+              val = runtime.StrArray([])
+            else:
+              val = None  # 'export a' -- only changing flags, may exist
 
         # NOTE: In bash and mksh, declare -a myarray makes an empty cell with
         # Undef value, but the 'array' attribute.

core/runtime.asdl

@@ -32,7 +32,7 @@ module runtime
   -- For storing a variable.
   cell = (value val, bool exported, bool readonly)
 
-  var_flags = Exported | ReadOnly
+  var_flags = Exported | ReadOnly | Array | AssocArray
   scope = TempEnv | LocalOnly | GlobalOnly | Dynamic
 
   -- For assignment, evaluated to osh_ast.lhs_expr

core/word_compile.py

@@ -110,8 +110,12 @@ def ParseAssignFlags(flag_args):
         flags.append(var_flags_e.Exported)
       elif char == 'r':
         flags.append(var_flags_e.ReadOnly)
+      elif char == 'a':
+        flags.append(var_flags_e.Array)
+      elif char == 'A':
+        flags.append(var_flags_e.AssocArray)
       else:
-        # -a is ignored right now?
+        # TODO: Throw an error?
         pass
   return flags
 

scripts/complete.sh

@@ -57,14 +57,18 @@ list-distro() {
 }
 
 # After running this, source testdata/completion/git-completion.bash
-git-demo() {
-  env -i OSH_CRASH_DUMP_DIR=_tmp bin/osh
+fresh-osh-with-dump() {
+  env -i OSH_CRASH_DUMP_DIR=_tmp bin/osh "$@"
 }
 
 bash-completion() {
   # This is a patched version
-  env -i OSH_CRASH_DUMP_DIR=_tmp bin/osh \
-    /usr/share/bash-completion/bash_completion.osh
+  fresh-osh-with-dump /usr/share/bash-completion/bash_completion.osh
+}
+
+# This should do nothing
+git-completion() {
+  fresh-osh-with-dump testdata/completion/git-completion.bash
 }
 
 "$@"