[errors] Remove unnecessary SetTokenForLine()

It's only for $LINENO and the fallback.

Doesn't apply to ShFunction

    f() { echo hi; }

or

    proc p { echo hi }

Part of #1707

Should remove from 'if' too

osh/cmd_eval.py

@@ -1169,8 +1169,9 @@ def _Dispatch(self, node, cmd_st):
 
             elif case(command_e.ControlFlow):
                 node = cast(command.ControlFlow, UP_node)
+
                 keyword = node.keyword
-                self.mem.SetTokenForLine(node.keyword)
+                self.mem.SetTokenForLine(keyword)
 
                 if node.arg_word:  # Evaluate the argument
                     str_val = self.word_ev.EvalWordToString(node.arg_word)
@@ -1480,7 +1481,7 @@ def _Dispatch(self, node, cmd_st):
 
             elif case(command_e.ShFunction):
                 node = cast(command.ShFunction, UP_node)
-                self.mem.SetTokenForLine(node.name_tok)
+
                 if node.name in self.procs and not self.exec_opts.redefine_proc_func(
                 ):
                     e_die(
@@ -1494,7 +1495,6 @@ def _Dispatch(self, node, cmd_st):
             elif case(command_e.Proc):
                 node = cast(command.Proc, UP_node)
 
-                self.mem.SetTokenForLine(node.name)
                 proc_name = lexer.TokenVal(node.name)
                 if proc_name in self.procs and not self.exec_opts.redefine_proc_func(
                 ):

test/runtime-errors.sh

@@ -1066,6 +1066,14 @@ fallback_locations() {
 
   _error-case 'if s=$(true) y=$(( 3 ** -2 )); then echo hi; fi'
 
+  _error-case 'shopt -s strict_arith; x=a; echo $(( x ))'
+  _error-case 'shopt -s strict_arith; x=a; echo $(( $x ))'
+  _error-case 'shopt -s strict_arith; x=a; [[ $x -gt 3 ]]'
+  _error-case 'shopt -s strict_arith; shopt -u eval_unsafe_arith; x=a; [[ $x -gt 3 ]]'
+
+  _error-case 'shopt -s strict_arith; x=0xgg; echo $(( x ))'
+
+
   echo done
 }