Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

echo and printf don't check write() failure #1103

Closed
andychu opened this issue Mar 9, 2022 · 2 comments
Closed

echo and printf don't check write() failure #1103

andychu opened this issue Mar 9, 2022 · 2 comments
Labels
bug divergence pending-release

Comments

@andychu
Copy link
Contributor

andychu commented Mar 9, 2022

e.g. disk full to /dev/full

This is inherited from Python, we should fix it:

https://blog.sunfishcode.online/bugs-in-hello-world/

64903ae
@andychu andychu added the bug label Feb 24, 2024
@andychu
Copy link
Contributor Author

andychu commented May 21, 2024 •
edited
Loading

Or really fwrite() and fflush() failure, which matters because we use libc I/O

andychu pushed a commit that referenced this issue May 21, 2024
[core] Check errors from fflush() after all builtins
ef59d63 
e.g. for disk full error or ulimit error, when redirecting builtin
stdout to a file

This is part of issue #1103.
andychu pushed a commit that referenced this issue May 21, 2024
[core] Also catch handle IOError while running builtins
fb9c867 
Not just upon fflush()

This is the rest of #1103.
@andychu
Copy link
Contributor Author

andychu commented Jun 20, 2024

Released - https://www.oilshell.org/blog/2024/06/release-0.22.0.html

@andychu andychu closed this as completed Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug divergence pending-release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andychu