New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generated ASDL code should support garbage collection #1176
Labels
Comments
Progress: a1120f2 |
Issue with generated code. There are 2 allocations in initializer lists. Doesn't that break a GC invariant?
|
I think we need a plain old function wrapper for every type. Just like NewStr / NewList / NewDict functions, we need |
andychu
pushed a commit
that referenced
this issue
Jun 26, 2022
See build/dev.sh test-all-asdl-gc This is part of #1176. - Generate NewStr() and NewList(). - In mylib.h, this is C++ 'new'. - In gc_heap.h, this will be Alloc<>
andychu
pushed a commit
that referenced
this issue
Jun 26, 2022
This now crashes on the garbage collector. Part of #1176.
At least two parts to this task:
|
andychu
pushed a commit
that referenced
this issue
Jul 3, 2022
For both ASDL and mycpp. Instead of separate files, we use #ifdef LEAKY_BINDINGS in the same file. - remove asdl/runtime.gc.{cc,h}, and don't generate _build/dev/foo_asdl.gc.{cc,h} - mycpp has a straggler for NewList<> that we can get rid of later Related to #1176. The ASDL code will support both leaky and GC at once.
andychu
pushed a commit
that referenced
this issue
Oct 1, 2022
Preparing for adding field masks, which is #1176.
Released: https://www.oilshell.org/release/0.12.7/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Parts
build/dev.sh oil-asdl-to-cpp-gc
should compileasdl/gc_test.cc
-- this should be able to pretty printThe text was updated successfully, but these errors were encountered: